Closed Bug 1657743 Opened 4 years ago Closed 4 years ago

Add ability to use the new non-native theming implementation using the `widget.disable-native-theme-for-content` pref

Categories

(Core Graveyard :: Widget: Android, enhancement)

enhancement

Tracking

(firefox81 fixed)

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: spohl, Assigned: spohl)

References

Details

Attachments

(2 files)

The idea is to move the original, currently active implementation of non-native theming for Android to nsNativeThemeAndroid to mirror behavior on platforms where we have native theming. We can then use the widget.disable-native-theme-for-content pref to enable the new non-native theming implementation.

Adding n-i in case Phabricator didn't properly notify you of the questions there.

Flags: needinfo?(emilio)

Whoops, sorry, I had missed, thanks for the ni :)

You are not changing behavior but are changing whether the nativeThemePref reftest annotation matches. For example, you need to change this line to be random-if(gtkWidget||Android) and such.

Flags: needinfo?(emilio)

Or do || sandbox.Android here, but that may be not great because then you have no way to differentiate the old and new non-native theme.

Pushed by spohl@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/30d39d5782d8 Add ability to enable the new non-native theming on Android. r=emilio,geckoview-reviewers,snorp https://hg.mozilla.org/integration/autoland/rev/dd3a1cf66864 Fix reftests. r=emilio
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: