Optimise testing functions in Cache and Warp
Categories
(Core :: JavaScript Engine: JIT, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox81 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
Details
Attachments
(3 files)
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
This is currently a NOP until bug 1655773 has been implemented.
Depends on D86526
|
|
Assignee | |
Comment 3•4 years ago
|
||
WarpCacheIRTranspiler::emitAssertRecoveredOnBailoutResult() was copied from the
MCallOptimize implementation. A new addEffectfulUnsafe() helper was added to
avoid triggering the safety assertions in addEffectful(). The MResumePoint
also needs to be created manually to avoid triggering assertions in the
WarpCacheIRTranspiler::resumeAfter() helper. Bypassing the safety assertions
should be okay in this case, because assertRecoveredOnBailout() is a fuzzy
unsafe testing function, so we can directly control how it is called.
JIT tests which don't (yet) pass in Warp have been disabled and annotated
with "TODO(Warp)".
Drive-by change:
- Use
add()inWarpCacheIRTranspiler::addDataViewData().
Depends on D86527
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/39731b445885
https://hg.mozilla.org/mozilla-central/rev/508fbac0215e
https://hg.mozilla.org/mozilla-central/rev/bbdd9a249156
Description
•