Steps to reproduce:

1. Have at least one account set up
2. Navigate to account settings
3. click "account actions" button menu
4. select "add mail account"

What happens:

Nothing.

Expected result:

Add mail account UI window appears.

--

2020-08-15T02:25:30.783000: DEBUG : Found commit message:
Bug 1655289 - Fix UI issues with tooltips and opening dialogs in new Account Central. r=Paenglab

2020-08-15T02:25:30.783000: DEBUG : Did not find a branch, checking all integration branches
2020-08-15T02:25:30.783000: INFO : The bisection is done.
2020-08-15T02:25:30.798000: INFO : Stopped

Asif, thanks for finding the regression.
This will block release of 78.2

There is a logged exception in TB 78.2.0-pre build 1:

[Exception... "Illegal value" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: chrome://messenger/content/accountUtils.js :: msgNewMailAccount :: line 523" data: no]

accountUtils.js:523 uses the raw account manager window

window.openDialog(

but it should probably be

window.docShell.rootTreeItem.domWindow.openDialog(

See attached patch for the trivial fix (relative to comm-central for convenience, but I did not actually build comm-central).

Sorry, wrong branch – the previous patch was not suitable for comm-central, as rootTree has since been obsoleted in bug 1638153. The new convention there is

window.browsingContext.topChromeWindow.openDialog(

So this is the patch for comm-central, and I'll provide the original patch with the correct comm-esr78 header once the source tree finishes downloading...

Patch for comm-esr78. This is essentially the original fix posted earlier, but with the correct header for comm-esr78.

Again sorry for the confusion!

Are we able to add an automated test?

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/956e5e6501b3
Fix new mail account dialog, r=mkmelin

Comment on attachment 9170207 [details] [diff] [review]
Fix v2, comm-esr78

[Approval Request Comment]
Regression caused by (bug #): bug 1655289
User impact if declined: can't add an account from within the account manager
Testing completed (on c-c, etc.): yes - but this patch is different on trunk/78 due to m-c changes
Risk to taking this patch (and alternatives if risky): not risky but should be verified once landed

To clarify, since beta 78 are different testing on beta wouldn't have helped here.

Comment on attachment 9170206 [details] [diff] [review]
Fix v2, comm-central

We should still fix beta. Is this the right patch or the other one?

Yes trunk and beta would have the same fix. The incompatibility is from bug 1639107 (version 79)

Comment on attachment 9170206 [details] [diff] [review]
Fix v2, comm-central

[Triage Comment]
Approved for beta

Comment on attachment 9170207 [details] [diff] [review]
Fix v2, comm-esr78

[Triage Comment]
Approved for esr78

Thunderbird 80.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/319fac6c3985

I created my Comcast account, then used Account Settings > Account Actions > Add Mail Account to add my Gmail account in my test of the 80.0b5 release candidate on Ubuntu 18.04.5 LTS.

No problems encountered.

Thunderbird 78.2.0:
https://hg.mozilla.org/releases/comm-esr78/rev/79026cb30306

Another one not working in my testing of the 78.2.0 release candidate on Ubuntu 18.04.5 LTS. New profile.

Works when testing the correct build.

is this available somewhere for testing 78.2 pre? (as installable version?).

Otherwise, no testing of 78,2pre is possible, I am not able to add any account

The link in planning still points to a version where this does not work

https://archive.mozilla.org/pub/thunderbird/candidates/78.2.0-candidates/build1/

please reopen, this is still broken in 78RC1 on win10 64bit

This is WFM at least on linux using one the candidates from comment 23.
If you see a problem, please post details STR in a new bug.

(In reply to klaus from comment #23)

please reopen, this is still broken in 78RC1 on win10 64bit

WFM on Windows 10 x64 with Thunderbird 78.2.0-rc1 x64. Either "78RC1" refers to an old build, or you found a different bug.
In the latter case, please open a new bug with your STR as indicated by mkmelin.

what is WFM and STR?
I mean 78.2 RC1 as linked on planning

Works for me and Step to reproduce.

Which planning link? Is it the same as comment 22?

Thanks.
yes that link. Downloaded this morning.
As Wayne implied elsewhere, works after TB restart (same for folder pane, calendar display)