Closed
Bug 1660026
Opened 4 years ago
Closed 4 years ago
Move print preview handling code into print.js
Categories
(Toolkit :: Printing, task, P2)
Toolkit
Printing
Tracking
()
RESOLVED
FIXED
82 Branch
People
(Reporter: mstriemer, Assigned: mstriemer)
References
Details
(Whiteboard: [print2020_v81])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
In the TabDialogBox
patch the print preview creation has moved into print.js. We also need to wait to start the preview until we've looked up the available destinations and determined our initial settings.
It no longer makes sense to have the preview handling code in PrintUtils, it should be moved into print.js.
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → mstriemer
Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [print2020_v81]
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/10d210c411df
Move print preview updating code into print.js r=sfoster,emalysz
Comment 3•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox82:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Assignee | ||
Comment 5•4 years ago
|
||
Comment on attachment 9170968 [details]
Bug 1660026 - Move print preview updating code into print.js
Beta/Release Uplift Approval Request
- User impact if declined: No user impact, but part of a refactoring to improve the print preview stability.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This simply moves code from one file to another.
- String changes made/needed: No
Flags: needinfo?(mstriemer)
Attachment #9170968 -
Flags: approval-mozilla-beta?
Comment 6•4 years ago
|
||
Comment on attachment 9170968 [details]
Bug 1660026 - Move print preview updating code into print.js
Approved for 81.0b2.
Attachment #9170968 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 7•4 years ago
|
||
bugherder uplift |
status-firefox81:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•