Closed
Bug 1653317
Opened 4 years ago
Closed 4 years ago
Use TabDialogBox for print UI
Categories
(Toolkit :: Printing, enhancement, P1)
Toolkit
Printing
Tracking
()
RESOLVED
FIXED
81 Branch
| Tracking | Status | |
|---|---|---|
| firefox81 | --- | fixed |
People
(Reporter: mstriemer, Assigned: mstriemer)
References
Details
(Whiteboard: [print2020_v81])
Attachments
(1 file, 2 obsolete files)
|
(deleted),
text/x-phabricator-request
|
Details |
When the TabDialogBox is ready we should move our dialog to use it since it handles some cases we haven't dealt with and will reuse that code rather than writing our own.
|
Assignee | |
Updated•4 years ago
|
|
||
Updated•4 years ago
|
Whiteboard: [print2020_v80] → [print2020_v81]
|
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
Assignee: nobody → mstriemer
Status: NEW → ASSIGNED
|
||
Updated•4 years ago
|
Attachment #9169235 -
Attachment description: Bug 1653317 - Use TabDialogBox for tab modal print UI → Bug 1653317 - Part 1: Use TabDialogBox for tab modal print UI
|
|
Assignee | |
Comment 7•4 years ago
|
||
Depends on D86597
|
||
Comment 8•4 years ago
|
||
The initial focus sometimes failed because print.html was not fully initialized.
Setting mozSubdialogReady makes SubDialog wait for the async init to ensure
the focus call succeeds.
|
|
||
Updated•4 years ago
|
Attachment #9170683 -
Attachment description: Bug 1653317 - Fixed initial focus and ESC hotkey on print preview. r=mstriemer → Bug 1653317 - Fixed initial focus and ESC hotkey on print UI. r=mstriemer
|
|
||
Updated•4 years ago
|
Attachment #9169235 -
Attachment description: Bug 1653317 - Part 1: Use TabDialogBox for tab modal print UI → Bug 1653317 - Use TabDialogBox for tab modal print UI
|
|
||
Comment 9•4 years ago
|
||
Comment on attachment 9170533 [details]
Bug 1653317 - Part 2: Move print preview updating code into print.js
Revision D87366 was moved to bug 1660026. Setting attachment 9170533 [details] to obsolete.
Attachment #9170533 -
Attachment is obsolete: true
|
|
||
Updated•4 years ago
|
Attachment #9170683 -
Attachment is obsolete: true
|
||
Comment 10•4 years ago
|
||
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6e38ea8c830c Use TabDialogBox for tab modal print UI r=Gijs,pbz
|
||
Updated•4 years ago
|
|
||
Comment 11•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox81:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•