Closed Bug 1660168 Opened 4 years ago Closed 4 years ago

Set marionette.actors.enabled to true by default for Fission builds

Categories

(Remote Protocol :: Marionette, task, P1)

Default
task

Tracking

(Fission Milestone:M7, firefox84 fixed)

RESOLVED FIXED
84 Branch
Fission Milestone M7
Tracking Status
firefox84 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [marionette-fission-mvp][simple])

Attachments

(1 file)

Once we have an actor code path for all the commands we should enable the preference by default for Fission builds in CI. That should happen for the Mn, Wdspec, and web-platform tests including reftests.

Whiteboard: [marionette-fission-mvp]
Fission Milestone: --- → M6c
Depends on: 1660781
Depends on: 1660881
Blocks: 1580699
No longer blocks: 1580699
Blocks: 1580699
Blocks: 1519354

Moving marionette-fission-mvp bugs from Fission Nightly Experiment milestone (M6b) to Fission Beta milestone (M7).

Fission Milestone: M6c → M7
Whiteboard: [marionette-fission-mvp] → [marionette-fission-mvp][simple]
Blocks: 1669169
Blocks: 1580699

Here a try build for Fission related jobs using Marionette / geckodriver:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2f55fe8edaa1d7f292df86060fc9ae81d04421f5

I will add blocking bugs to the dependency list as soon as test results are available.

No longer depends on: marionette-actor
Depends on: 1671347
Depends on: 1671370
Depends on: 1671372
Depends on: 1671770
Blocks: 1664968
Depends on: 1673326
Depends on: 1673327

With the duplicate bug 1673326 it's clear that we also need a way to allow tests to query for the actor state. Right now we only set the internal state but don't update the preference. Also we run the preference check each and every time a command gets called. We should change it so that it's done only once for the very first time.

Blocks: 1532589

Most recent try build with the patch from the last remaining bug included is totally green:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d0386b679d693edaa5ebe1e2e63279db4befc13

So lets get this enabled tomorrow.

Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: P3 → P1
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/920ae97a281f
[marionette] Enable usage of Marionette's JSWindowActor by default for Fission builds. r=marionette-reviewers,jdescottes
Regressions: 1673851
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: