Closed Bug 1671372 Opened 4 years ago Closed 4 years ago

Perma Fis /webdriver/tests/release_actions/release.py | test_no_browsing_context - AssertionError: unknown error (500): TypeError: can't access property "getActor", browsingContext.currentWindowGlobal is null

Categories

(Testing :: Marionette Client and Harness, defect, P1)

Product:
Testing
Component:
Marionette Client and Harness
Type:
defect

Tracking

(Fission Milestone:M7, firefox84 fixed)

Status:
RESOLVED FIXED
Milestone:
84 Branch
Project Flags:
Fission Milestone M7
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: whimboo)

References

Details

(Keywords: assertion, intermittent-failure, Whiteboard: [marionette-fission-mvp][simple], [wptsync upstream])

Attachments

(2 files)

Bug 1671372 - [marionette] "WebDriver:ReleaseActions" has to check the current and not top-level browsing context.
(deleted), text/x-phabricator-request
Details
Bug 1671372 - [wdspec] "Release Actions" has to check for current and not top-level browsing context.
(deleted), text/x-phabricator-request
Details

Here the exact failure:

[task 2020-10-15T09:59:17.924Z] 09:59:17     INFO - PID 9484 | 1602755957921	Marionette	DEBUG	0 -> [0,55,"WebDriver:ElementClick",{"id":"84aa04ee-de73-48a2-bb70-cf65e9d42814"}]
[task 2020-10-15T09:59:17.944Z] 09:59:17     INFO - PID 9484 | 1602755957933	Marionette	TRACE	[41] Frame with id 12884901890 got removed
[task 2020-10-15T09:59:17.944Z] 09:59:17     INFO - PID 9484 | 1602755957934	Marionette	TRACE	Received DOM event click for [object HTMLInputElement]
[task 2020-10-15T09:59:17.945Z] 09:59:17     INFO - PID 9484 | 1602755957935	Marionette	TRACE	Canceled page load listener because current frame has been removed
[task 2020-10-15T09:59:17.946Z] 09:59:17     INFO - PID 9484 | 1602755957935	Marionette	DEBUG	0 <- [1,55,null,{"value":null}]
[task 2020-10-15T09:59:17.946Z] 09:59:17     INFO - PID 9484 | 1602755957937	webdriver::server	DEBUG	<- 200 OK {"value":null}
[task 2020-10-15T09:59:17.946Z] 09:59:17     INFO - PID 9484 | 1602755957939	webdriver::server	DEBUG	-> DELETE /session/cc8cb509-4130-4306-b8a2-462e2c87e0b3/actions
[task 2020-10-15T09:59:17.947Z] 09:59:17     INFO - PID 9484 | 1602755957940	Marionette	DEBUG	0 -> [0,56,"WebDriver:ReleaseActions",{}]
[task 2020-10-15T09:59:17.948Z] 09:59:17     INFO - PID 9484 | 1602755957940	Marionette	DEBUG	0 <- [1,56,{"error":"unknown error","message":"TypeError: can't access property \"getActor\", browsingContext.currentWindowGlobal  ... ionette/content/driver.js:382:3\nGeckoDriver.prototype.releaseActions@chrome://marionette/content/driver.js:1965:16\n"},null]
[task 2020-10-15T09:59:17.950Z] 09:59:17     INFO - PID 9484 | Marionette threw an error: TypeError: can't access property "getActor", browsingContext.currentWindowGlobal is null
[task 2020-10-15T09:59:17.950Z] 09:59:17     INFO - PID 9484 | GeckoDriver.prototype.getActor@chrome://marionette/content/driver.js:382:3
[task 2020-10-15T09:59:17.950Z] 09:59:17     INFO - PID 9484 | GeckoDriver.prototype.releaseActions@chrome://marionette/content/driver.js:1965:16

As it looks like this needs a fix for bug 1666204.

Blocks: marionette-actor, 1660168
Depends on: 1666204
Whiteboard: [marionette-fission-mvp][simple]
Summary: Perma Fis /webdriver/tests/release_actions/release.py | test_no_browsing_context - AssertionError: unknown error (500): TypeError: can't access property "getActor", browsingContext.currentWindowGlobal is null → Perma Fis Wd | test_no_browsing_context - AssertionError: unknown error (500): TypeError: can't access property "getActor", browsingContext.currentWindowGlobal is null

Tracking marionette-fission-mvp bugs for Fission Beta milestone (M7)

Fission Milestone: --- → M7

At least for WebDriver:ReleaseActions we have an inappropriate browsing context check:

https://searchfox.org/mozilla-central/rev/e0eb861a187f0bb6d994228f2e0e49b2c9ee455e/testing/marionette/driver.js#1961,1965

While the check in line 1961 operates on the top-level browsing context, the actor used to run the command is the current one.

We will have to update line 1961 to also use the current browsing context.

Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: P5 → P1

Lets keep this bug for release actions.

Summary: Perma Fis Wd | test_no_browsing_context - AssertionError: unknown error (500): TypeError: can't access property "getActor", browsingContext.currentWindowGlobal is null → Perma Fis /webdriver/tests/release_actions/release.py | test_no_browsing_context - AssertionError: unknown error (500): TypeError: can't access property "getActor", browsingContext.currentWindowGlobal is null
No longer depends on: 1666204
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/693a38392149
[marionette] "WebDriver:ReleaseActions" has to check the current and not top-level browsing context. r=marionette-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/cb435bbb7984
[wdspec] "Release Actions" has to check for current and not top-level browsing context. r=webdriver-reviewers,maja_zf

https://hg.mozilla.org/mozilla-central/rev/693a38392149
https://hg.mozilla.org/mozilla-central/rev/cb435bbb7984

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch

I miss a sync request from the wpt bot. James can you please check?

Flags: needinfo?(james)
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/26223 for changes under testing/web-platform/tests
Whiteboard: [marionette-fission-mvp][simple] → [marionette-fission-mvp][simple], [wptsync upstream]
Upstream PR merged by moz-wptsync-bot
Flags: needinfo?(james)
Product: Testing → Remote Protocol
Moving bug to Testing::Marionette Client and Harness component per bug 1815831.
Component: Marionette → Marionette Client and Harness
Product: Remote Protocol → Testing
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: