Closed Bug 1661000 Opened 4 years ago Closed 4 years ago

Don't canonize url immediately after a paste

Categories

(Firefox :: Address Bar, defect, P2)

defect
Points:
3

Tracking

()

RESOLVED FIXED
84 Branch
Iteration:
84.2 - Nov 2 - Nov 15
Tracking Status
firefox84 --- fixed

People

(Reporter: mak, Assigned: daisuke)

References

(Regressed 1 open bug)

Details

(Keywords: papercut, parity-chrome)

Attachments

(1 file)

I've seen various reports of users pressing Enter after a CTRL+V, while they still keep CTRL pressed. This causes us to canonize the word (adding www. and .com to it) and we end up visiting a non-existing page instead of searching for the pasted word.

To prevent this, we could skip canonization if it happens at a short time after a paste.

How short? This really feels like mystery meat navigation - software really shouldn't do magical behaviors that result in inconsistent behaviors with the same user actions.

(In reply to Asif Youssuff from comment #1)

How short? This really feels like mystery meat navigation - software really shouldn't do magical behaviors that result in inconsistent behaviors with the same user actions.

In general I agree, but I've seen quite a few reports, so it's clear this is an annoyance for users, and canonization is a completely undiscoverable feature, so it's hard for the user to understand what's up.
We could probably check for a CTRL keyup after CTRL+V, if it didn't happen and Enter is pressed before 100ms elapsed, assume the user meant to search. CTRL+V and then CTRL+Enter would still canonize reliably. CTRL+V+Enter not.

interestingly enough, also Chrome has canonization, what they seem to do is just to check for a ctrl keyup, so we could just do the same and be consistent with them.

Type: enhancement → defect
Priority: P3 → P2
Keywords: parity-chrome
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Keywords: papercut
Iteration: --- → 84.2 - Nov 2 - Nov 15
Points: --- → 3
Attachment #9182298 - Attachment description: Bug 1661000: Avoid canonizatoin if ctrl key is still alived. → Bug 1661000: Avoid urlbar search string canonization if ctrl key comes from a previous action.
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4c449cde60a7 Avoid urlbar search string canonization if ctrl key comes from a previous action. r=mak
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Regressions: 1683691
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: