Closed Bug 1661668 Opened 4 years ago Closed 4 years ago

Do some cleaning in setSinkId code paths

Categories

(Core :: Audio/Video: MediaStreamGraph, task, P2)

Product:
Core
Component:
Audio/Video: MediaStreamGraph
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: pehrsons, Assigned: pehrsons)

References

Details

Attachments

(11 files)

Bug 1661668 - Rename CrossGraphManager to CrossGraphPort. r?padenot
(deleted), text/x-phabricator-request
Details
Bug 1661668 - Avoid a RefPtr copy when creating a CrossGraphPort. r?padenot
(deleted), text/x-phabricator-request
Details
Bug 1661668 - Make CrossGraphPort::mSourcePort const. r?padenot
(deleted), text/x-phabricator-request
Details
Bug 1661668 - Clarify ownership of transmitter and receiver in CrossGraphPort. r?padenot
(deleted), text/x-phabricator-request
Details
Bug 1661668 - Make CrossGraphTransmitter::mReceiver const. r?padenot
(deleted), text/x-phabricator-request
Details
Bug 1661668 - Avoid returning raw pointers from CrossGraphPort::Connect because of the leak risk. r?padenot
(deleted), text/x-phabricator-request
Details
Bug 1661668 - Remove unnecessary "virtual" keywords from CrossGraphPort.h. r?padenot
(deleted), text/x-phabricator-request
Details
Bug 1661668 - Remove unnecessary "explicit" keyword from CrossGraphReceiver. r?padenot
(deleted), text/x-phabricator-request
Details
Bug 1661668 - Don't let CrossGraphTransmitter masquerade as a ForwardedInputTrack. r?padenot
(deleted), text/x-phabricator-request
Details
Bug 1661668 - Capture `this` in HTMLMediaElement::SetSinkId captures, for readability. r?padenot
(deleted), text/x-phabricator-request
Details
Bug 1661668 - Clarify MediaInputPort threading model. r?padenot
(deleted), text/x-phabricator-request
Details

In part because this code diverts from the styleguide in some places; in part so I can learn the code, and adapt it to what I find is more descriptive naming, for instance.

"Manager" is vague, and it seems to mostly keep some members around rather than
managing them. Port is analogue to MediaInputPort in that it acts as a link
between two tracks. Neither type of port does very much heavy lifting -- they
are similarly dumb.

Depends on D88813

We've been working to reduce the depth of the class hierarchy, so let's not add
more. Broadening it is simple enough. This patch makes CrossGraphTransmitter a
sub class of ProcessedMediaTrack instead. As such it doesn't need a mSegment
member, among other things.

Depends on D88819

Depends on D88821

Attachment #9173042 - Attachment description: Bug 1661668 - Rename CrossGraphManager to CrossTrackPort. r?padenot → Bug 1661668 - Rename CrossGraphManager to CrossGraphPort. r?padenot
Pushed by pehrsons@gmail.com: https://hg.mozilla.org/integration/autoland/rev/e1620a74a759 Rename CrossGraphManager to CrossGraphPort. r=padenot https://hg.mozilla.org/integration/autoland/rev/0f719a4e5fe1 Avoid a RefPtr copy when creating a CrossGraphPort. r=padenot https://hg.mozilla.org/integration/autoland/rev/374e873718fa Make CrossGraphPort::mSourcePort const. r=padenot https://hg.mozilla.org/integration/autoland/rev/32dae00d3edc Clarify ownership of transmitter and receiver in CrossGraphPort. r=padenot https://hg.mozilla.org/integration/autoland/rev/28e0a3c98004 Make CrossGraphTransmitter::mReceiver const. r=padenot https://hg.mozilla.org/integration/autoland/rev/c7a33f295834 Avoid returning raw pointers from CrossGraphPort::Connect because of the leak risk. r=padenot https://hg.mozilla.org/integration/autoland/rev/485cc39ac97e Remove unnecessary "virtual" keywords from CrossGraphPort.h. r=padenot https://hg.mozilla.org/integration/autoland/rev/2c7cd062626a Remove unnecessary "explicit" keyword from CrossGraphReceiver. r=padenot https://hg.mozilla.org/integration/autoland/rev/5f79701f61c3 Don't let CrossGraphTransmitter masquerade as a ForwardedInputTrack. r=padenot https://hg.mozilla.org/integration/autoland/rev/3afcd9d68d5a Capture `this` in HTMLMediaElement::SetSinkId captures, for readability. r=padenot https://hg.mozilla.org/integration/autoland/rev/56cb58f400b5 Clarify MediaInputPort threading model. r=padenot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: