Closed
Bug 1661649
Opened 4 years ago
Closed 4 years ago
Setting default sink id on a track with no prior sink id fails an assert
Categories
(Core :: Audio/Video: MediaStreamGraph, task, P2)
Core
Audio/Video: MediaStreamGraph
Tracking
()
RESOLVED
FIXED
82 Branch
| Tracking | Status | |
|---|---|---|
| firefox82 | --- | fixed |
People
(Reporter: pehrsons, Assigned: pehrsons)
References
Details
Attachments
(3 files)
AudioStreamTrack::SetAudioOutputDevice seems to assume that when CrossGraphManager::Connect returns null we switch back from a non-null manager.
However, this is not always the case.
STR:
Have a media element playing a MediaStream with audio
Set the sink id of said media element to an explicit device
Set the sink id of said media element to the default device (i.e., "")
Add a fresh audio track to said media element
Expected:
Default device plays the fresh audio track
Actual: Assertion failure
|
Assignee | |
Comment 1•4 years ago
|
||
Depends on D88822
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D88823
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D88825
Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/33fa9e803dec
Minor test_setSinkId.html fixes. r=padenot
https://hg.mozilla.org/integration/autoland/rev/82373b2b236a
Add mochitest. r=padenot
https://hg.mozilla.org/integration/autoland/rev/054f617aae48
Allow re-setting the default output device for a key on AudioStreamTrack. r=padenot
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/33fa9e803dec
https://hg.mozilla.org/mozilla-central/rev/82373b2b236a
https://hg.mozilla.org/mozilla-central/rev/054f617aae48
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox82:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•