Use the ResourceWatcher API to fetch Breakpoints
Categories
(DevTools :: Debugger, enhancement, P2)
Tracking
(Fission Milestone:M7, firefox87 fixed)
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
(Whiteboard: dt-fission-m3-mvp)
Attachments
(4 files)
In order to support early breakpoint (bug 1573327), we probably have to introduce a "breakpoint" resource, which will be emitted very early as soon as the process or thread starts.
And to do that, the first step would be to implement a legacy listener which would map ThreadFront's paused and resumed RDP event into resources.
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
||
Comment 2•4 years ago
|
||
Tracking dt-fission-m2-reserve bugs for Fission Beta milestone (M7).
|
||
Updated•4 years ago
|
|
||
Comment 3•4 years ago
|
||
Bulk move of all dt-fission-m2-reserve bugs to Fission MVP milestone.
|
|
Assignee | |
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 4•4 years ago
|
||
|
|
Assignee | |
Comment 5•4 years ago
|
||
|
|
Assignee | |
Comment 6•4 years ago
|
||
|
|
Assignee | |
Comment 7•4 years ago
|
||
The two "location" expressions being added, removed and re-added
are mixed up in the UI if we don't wait for the evaluation of the first,
before removing and re-adding it.
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3f4451fcdc25 [devtools] Introduce breakpoint resource. r=nchevobbe,jdescottes https://hg.mozilla.org/integration/autoland/rev/9974b7eea47b [devtools] Rename ensureSourceActor to waitForSourceActorToBeRegisteredInStore. r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/8562cd4f988b [devtools] Wait for EVALUATE_EXPRESSIONS actions from browser_dbg-expressions.js r=nchevobbe
|
||
Comment 9•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3f4451fcdc25
https://hg.mozilla.org/mozilla-central/rev/9974b7eea47b
https://hg.mozilla.org/mozilla-central/rev/8562cd4f988b
|
||
Comment 10•4 years ago
|
||
Backed out 3 changesets (Bug 1662129) for causing devtools failures in browser_dbg-pause-points.js a=backout
Backout link: https://hg.mozilla.org/mozilla-central/rev/1a895ef04f9f98bf71265bc9efcc0932ca764f0b
Failure log: https://treeherder.mozilla.org/logviewer?job_id=327345718&repo=autoland&lineNumber=7725
|
|
Assignee | |
Comment 11•4 years ago
|
||
So, I'm hitting an intermittent failure on:
https://searchfox.org/mozilla-central/source/devtools/client/debugger/test/mochitest/browser_dbg-pause-points.js#69
Current thread has paused or resumed exception while running:
await dbg.actions.stepOver(getThreadContext(dbg));
I think it relates to not waiting correctly for full resume.
If I add some more wait code around resume, I'm hitting yet another intermittent, this time even more intermittent:
Error: resume command sent while not paused. Currently attached exception while running the same line of code:
await dbg.actions.stepOver(getThreadContext(dbg));
Unfortunately, I don't reproduce locally, which makes it hard to debug...
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 12•4 years ago
|
||
I think the test wasn't waiting correctly for initial pause event, let's see if that's green now:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e2d5c9abbb70742be67d13824cd360b9500d51f
|
|
Assignee | |
Comment 13•4 years ago
|
||
As we weren't waiting for pause when calling the first debugger statement,
things were very much confused in stepOvers. We were asserting the initial debugger statement frame,
while, in stepOvers waiting for the first step over "paused" event.
|
||
Comment 14•4 years ago
|
||
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a4c10e3ccf29 [devtools] Introduce breakpoint resource. r=nchevobbe,jdescottes https://hg.mozilla.org/integration/autoland/rev/83b191c95d22 [devtools] Rename ensureSourceActor to waitForSourceActorToBeRegisteredInStore. r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/d32a6cd1eb33 [devtools] Wait for EVALUATE_EXPRESSIONS actions from browser_dbg-expressions.js r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/0b44fc052838 [devtools] Wait for initial debugger statement breakpoint in browser_dbg-pause-points.js. r=nchevobbe
|
||
Comment 15•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a4c10e3ccf29
https://hg.mozilla.org/mozilla-central/rev/83b191c95d22
https://hg.mozilla.org/mozilla-central/rev/d32a6cd1eb33
https://hg.mozilla.org/mozilla-central/rev/0b44fc052838
|
|
||
Comment 16•4 years ago
|
||
This completed dt-fission-m3-mvp bug should have Fission Milestone M7 Beta.
Description
•