Closed Bug 1683139 Opened 4 years ago Closed 4 years ago

Implement breakpoints listening via the ResourceWatcher API on the actor side

Categories

(DevTools :: Debugger, enhancement, P3)

Product:
DevTools
Component:
Debugger
Type:
enhancement

Tracking

(Fission Milestone:M7, firefox87 fixed)

Status:
RESOLVED FIXED
Milestone:
87 Branch
Project Flags:
Fission Milestone M7
Tracking Flags:
Tracking Status
firefox87 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission-m3-mvp )

Attachments

(4 files)

Bug 1683139 - [devtools] Implement breakpoint resource on server side via the watcher actor.
(deleted), text/x-phabricator-request
Details
Bug 1683139 - [devtools] Rename BREAKPOINT resource to THREAD_STATE.
(deleted), text/x-phabricator-request
Details
Bug 1683139 - [devtools] Avoid setting the same breakpoint more than once.
(deleted), text/x-phabricator-request
Details
Bug 1683139 - [devtools] Test setting many breakpoints on the same line.
(deleted), text/x-phabricator-request
Details

Similar to all bugs under meta bug 1626647, this is about implementing server side listening of breakpoints. The goal here is to be able to observe the breakpoint as early as the target starts running and avoid missing any early breakpoint.
Until this bug is done, we will miss very early breakpoints as the ThreadActor will emit an event, while the frontend isn't listening yet for the paused event.

Blocks: 1681699
Whiteboard: dt-fission-m3-mvp

Tracking dt-fission-m3-mvp bugs for Fission MVP.

Fission Milestone: --- → MVP
Severity: -- → S3
Priority: -- → P3
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED

This was causing _priorPause to be reset unexpectedly,
leading to lastPausedPacket being null and missing "paused" THREAD_STATE resource.

Moving some dt-fission-m3-mvp bugs from Fission MVP to M7 (blocking Beta experiment).

Fission Milestone: MVP → M7

I'm also cleaning up things in debugger tests in order to reuse the same helper to check for breakpoints info in the gutter.

Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5178ad3905fb [devtools] Rename BREAKPOINT resource to THREAD_STATE. r=jdescottes,nchevobbe https://hg.mozilla.org/integration/autoland/rev/ea0c6e4ae33d [devtools] Implement breakpoint resource on server side via the watcher actor. r=nchevobbe,jdescottes https://hg.mozilla.org/integration/autoland/rev/7d2113bf7e0e [devtools] Test setting many breakpoints on the same line. r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/d798378a9823 [devtools] Avoid setting the same breakpoint more than once. r=nchevobbe,jdescottes,devtools-backward-compat-reviewers
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: