Closed Bug 1665908 Opened 4 years ago Closed 4 years ago

Entering search mode does not clear one-off selection

Categories

(Firefox :: Address Bar, defect, P2)

Firefox 82
Desktop
Windows 10
defect
Points:
2

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox82 --- disabled
firefox83 --- fixed

People

(Reporter: alice0775, Assigned: daisuke)

References

Details

(Keywords: ux-consistency)

Attachments

(2 files)

Attached image screenshot (deleted) —

Steps to reproduce:

  1. Hit Ctrl+L so that Address Bar will get focus
  2. Hit Alt+↓ so that dropdown will appear
  3. Type @amazon[space]

Actual Results:
"Amazon.com" in Address Bar, but [G] is also highlighted in dropdown

Expected Results:
[G] should not be highlighted in this case

We should likely remove one-offs selection when entering search mode. Though I wonder if bug 1657676 changed the outcome here.

Blocks: 1647886
Severity: -- → S3
Depends on: 1657676
Priority: -- → P2

Bug 1657676 does make this a bit better. In this bug's STR, we'd show the Google search mode indicator on step 2. No results would be replaced. On step 3, the Google indicator would be replaced with the Amazon search indicator and the results would be replaced with Amazon search mode results. I think this new behaviour makes it pretty clear to the user what is happening. Regardless, we should probably run this one by UX.

Keywords: blocked-ux

Sorry, I meant bug 1664320 will make this better. That should land within a few hours.

Depends on: 1664320
No longer depends on: 1657676
Summary: inconsistency search engine in Address Bar → Entering search mode does not clear one-off selection
Assignee: nobody → daisuke
Status: NEW → ASSIGNED

Note here we are still waiting for UX feedback (blocked-ux keyword), we should coordinate with Verdi to figure out what's the right solution, it's possible the patch is already implementing the right thing, but we must confirm it with UX.

Ah, I see! Okay, I will wait for the feedback.

The original bug here doesn't happen anymore, though I can reproduce two related problems:

a.

  1. CTRL+L
    1a. [optional] type something
  2. ALT+DOWN
  3. type something more
  4. cycle through one-off buttons with ALT+DOWN
    => The chiclet keeps showing the original engine instead of updating to the currently selected one.

b.

  1. CTRL+L
  2. ALT+DOWN twice (the default engine should not be selected)
  3. CTRL+K
    => this enters search mode for the default engine (e.g. Google) but the other engine one-off button is still selected
    This is probably fixed by Daisuke's patch

Harry, apart from these bugs, are there actually questions for UX considered the original bug doesn't happen, nor what you meant in comment 2? Once we are in search mode any keyword typed after it should be considered just search text, based on recent fixes.

Flags: needinfo?(htwyford)

I filed a) as bug 1668012, so the remaining part here is b)

Discussed over Slack, there isn't anymore UX questioning here, so we can proceed with the suggested solution.

Flags: needinfo?(htwyford)
Keywords: blocked-ux
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7bc5f7b54912 Remove one-off button selection when entering search mode. r=mak
Points: --- → 2
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch

The patch landed in nightly and beta is affected.
:daisuke, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(daisuke)

The feature is disabled in 82.

Flags: needinfo?(daisuke)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: