Closed Bug 1664320 Opened 4 years ago Closed 4 years ago

Show search mode indicator when cycling through one-offs with the keyboard

Categories

(Firefox :: Address Bar, enhancement, P2)

enhancement
Points:
2

Tracking

()

RESOLVED FIXED
83 Branch
Iteration:
82.2 - Sep 7 - Sep 20
Tracking Status
firefox82 --- wontfix
firefox83 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached image cycling2.jpg (deleted) —

We should show the search mode indicator without executing a new query when the user cycles through one-offs with the keyboard. We should do this for both Arrowing and Alt+Arrowing through the one-offs. I clarified with UX that as of bug 1657212, Shift+Enter and Alt+Enter on a keyboard-selected one-off will execute a search immediately rather than enter search mode. This is fine, and we should still show the search mode indicator if a key-modifier is being is held down. The rationale is that the action following Enter will be related to the engine named in the search mode indicator regardless of key modifier: we will either enter that engine's search mode if nothing is held down, or perform a search immediately with that engine if a key modifier is held down.

Please see attached drawing. Please also see bug 1657676, which also concerns showing the search mode indicator without executing a new query.

Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 82.2 - Sep 7 - Sep 20
Blocks: 1665908
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/35e3da7b7672 Enter search mode preview when cycling through one-offs with the keyboard. r=adw
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Regressions: 1666087

Backed out from Gecko 82 (beta) for causing bug 1666087:

https://hg.mozilla.org/releases/mozilla-beta/rev/183b951ba5701d5d8ca1fd4184b5a14b3fc74f59

It remains in tree for Gecko 83 (central).

Status: RESOLVED → REOPENED
Flags: needinfo?(htwyford)
Resolution: FIXED → ---
Target Milestone: 82 Branch → ---

This is actually fixed in Nightly and not worth uplifting.

Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
Flags: needinfo?(htwyford)
Attachment #9176350 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: