Closed
Bug 1666519
Opened 4 years ago
Closed 4 years ago
Add localStorage resource
Categories
(DevTools :: Storage Inspector, enhancement, P3)
DevTools
Storage Inspector
Tracking
(Fission Milestone:M7, firefox84 fixed)
Tracking | Status | |
---|---|---|
firefox84 | --- | fixed |
People
(Reporter: ladybenko, Assigned: ladybenko)
References
(Blocks 2 open bugs)
Details
(Whiteboard: dt-fission-m2-mvp)
Attachments
(2 files)
Add a Fission-compatible localStorage
resource
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Priority: P1 → P3
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Whiteboard: dt-fission-m2-mvp
Assignee | ||
Comment 2•4 years ago
|
||
Updated•4 years ago
|
Attachment #9179933 -
Attachment description: Bug 1666519 - [devtools] Add localStorage resource → Bug 1666519 - Part 1: [devtools] Add localStorage resource
Pushed by balbeza@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/990b312b5abe Part 1: [devtools] Add localStorage resource r=ochameau https://hg.mozilla.org/integration/autoland/rev/94c066ab05dc Part 2: [devtools] Add fission test helpers + a test for localStorage r=jdescottes
Comment 5•4 years ago
|
||
Backed out 2 changesets (bug 1666519) for devtools leaks and failures.
Backout link: https://hg.mozilla.org/integration/autoland/rev/a4b23f6e3a386e2f1c704d227e968f81b9b6b651
Failures logs:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319265767&repo=autoland&lineNumber=2813
...
[task 2020-10-21T15:17:15.189Z] 15:17:15 INFO - Wait for runtime page to be rendered
[task 2020-10-21T15:17:15.190Z] 15:17:15 INFO - Buffered messages logged at 15:17:12
[task 2020-10-21T15:17:15.191Z] 15:17:15 INFO - Open about:devtools-toolbox page
[task 2020-10-21T15:17:15.191Z] 15:17:15 INFO - TEST-PASS | devtools/client/aboutdebugging/test/browser/browser_aboutdebugging_devtoolstoolbox_reload.js | about:debugging tab target appeared -
[task 2020-10-21T15:17:15.191Z] 15:17:15 INFO - TEST-PASS | devtools/client/aboutdebugging/test/browser/browser_aboutdebugging_devtoolstoolbox_reload.js | Inspect button for about:debugging appeared -
[task 2020-10-21T15:17:15.192Z] 15:17:15 INFO - Buffered messages logged at 15:17:13
[task 2020-10-21T15:17:15.195Z] 15:17:15 INFO - Wait for about:devtools-toolbox tab will be selected
[task 2020-10-21T15:17:15.195Z] 15:17:15 INFO - Select tool: accessibility
[task 2020-10-21T15:17:15.196Z] 15:17:15 INFO - Wait for requests to settle before reloading
[task 2020-10-21T15:17:15.197Z] 15:17:15 INFO - Reload about:devtools-toolbox page
[task 2020-10-21T15:17:15.198Z] 15:17:15 INFO - TEST-PASS | devtools/client/aboutdebugging/test/browser/browser_aboutdebugging_devtoolstoolbox_reload.js | Toolbox is re-created again -
[task 2020-10-21T15:17:15.199Z] 15:17:15 INFO - TEST-PASS | devtools/client/aboutdebugging/test/browser/browser_aboutdebugging_devtoolstoolbox_reload.js | about:devtools-toolbox is still selected -
[task 2020-10-21T15:17:15.199Z] 15:17:15 INFO - Check whether about:devtools-toolbox page displays correctly
[task 2020-10-21T15:17:15.200Z] 15:17:15 INFO - TEST-PASS | devtools/client/aboutdebugging/test/browser/browser_aboutdebugging_devtoolstoolbox_reload.js | about:devtools-toolbox page displays correctly -
[task 2020-10-21T15:17:15.201Z] 15:17:15 INFO - Close about:devtools-toolbox page
[task 2020-10-21T15:17:15.201Z] 15:17:15 INFO - Wait for removeTab
[task 2020-10-21T15:17:15.202Z] 15:17:15 INFO - Removing tab.
[task 2020-10-21T15:17:15.205Z] 15:17:15 INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2020-10-21T15:17:15.205Z] 15:17:15 INFO - Got event: 'TabClose' on [object XULElement].
[task 2020-10-21T15:17:15.210Z] 15:17:15 INFO - Tab removed and finished closing
[task 2020-10-21T15:17:15.210Z] 15:17:15 INFO - Wait for toolbox destroyed
[task 2020-10-21T15:17:15.210Z] 15:17:15 INFO - Buffered messages logged at 15:17:14
[task 2020-10-21T15:17:15.210Z] 15:17:15 INFO - Wait until aboutdebugging is selected
[task 2020-10-21T15:17:15.210Z] 15:17:15 INFO - Wait until about:devtools-toolbox is removed from debug targets
[task 2020-10-21T15:17:15.210Z] 15:17:15 INFO - Removing tab.
[task 2020-10-21T15:17:15.220Z] 15:17:15 INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2020-10-21T15:17:15.220Z] 15:17:15 INFO - Got event: 'TabClose' on [object XULElement].
[task 2020-10-21T15:17:15.220Z] 15:17:15 INFO - Tab removed and finished closing
[task 2020-10-21T15:17:15.220Z] 15:17:15 INFO - Leaving test bound
[task 2020-10-21T15:17:15.220Z] 15:17:15 INFO - Buffered messages finished
[task 2020-10-21T15:17:15.220Z] 15:17:15 INFO - TEST-UNEXPECTED-FAIL | devtools/client/aboutdebugging/test/browser/browser_aboutdebugging_devtoolstoolbox_reload.js | The main process DevToolsServer has no pending connection when the test ends -
[task 2020-10-21T15:17:15.222Z] 15:17:15 INFO - Stack trace:
[task 2020-10-21T15:17:15.222Z] 15:17:15 INFO - chrome://mochikit/content/browser-test.js:test_ok:1304
[task 2020-10-21T15:17:15.223Z] 15:17:15 INFO - chrome://mochitests/content/browser/devtools/client/shared/test/shared-head.js:cleanup:316
[task 2020-10-21T15:17:15.223Z] 15:17:15 INFO - GECKO(1515) | MEMORY STAT | vsize 3679MB | residentFast 560MB | heapAllocated 240MB
[task 2020-10-21T15:17:15.227Z] 15:17:15 INFO - TEST-OK | devtools/client/aboutdebugging/test/browser/browser_aboutdebugging_devtoolstoolbox_reload.js | took 42642ms
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319266003&repo=autoland&lineNumber=8958
...
[task 2020-10-21T15:22:45.995Z] 15:22:45 INFO - GECKO(1545) | SUMMARY: AddressSanitizer: 160264 byte(s) leaked in 433 allocation(s).
[task 2020-10-21T15:22:47.981Z] 15:22:47 INFO - GECKO(1545) | error: address range table at offset 0x5bf0 has an invalid tuple (length = 0) at offset 0x5c00
[task 2020-10-21T15:22:48.137Z] 15:22:48 INFO - GECKO(1545) | -----------------------------------------------------
[task 2020-10-21T15:22:48.137Z] 15:22:48 INFO - GECKO(1545) | Suppressions used:
[task 2020-10-21T15:22:48.138Z] 15:22:48 INFO - GECKO(1545) | count bytes template
[task 2020-10-21T15:22:48.138Z] 15:22:48 INFO - GECKO(1545) | 23 696 nsComponentManagerImpl
[task 2020-10-21T15:22:48.138Z] 15:22:48 INFO - GECKO(1545) | 633 18083 libfontconfig.so
[task 2020-10-21T15:22:48.140Z] 15:22:48 INFO - GECKO(1545) | 1 16384 libglib-2.0.so
[task 2020-10-21T15:22:48.140Z] 15:22:48 INFO - GECKO(1545) | 3 624 mozJSComponentLoader
[task 2020-10-21T15:22:48.140Z] 15:22:48 INFO - GECKO(1545) | -----------------------------------------------------
[task 2020-10-21T15:22:48.295Z] 15:22:48 INFO - TEST-INFO | Main app process: exit 0
[task 2020-10-21T15:22:48.295Z] 15:22:48 INFO - TEST-INFO | LeakSanitizer | To show the addresses of leaked objects add report_objects=1 to LSAN_OPTIONS
[task 2020-10-21T15:22:48.295Z] 15:22:48 INFO - TEST-INFO | LeakSanitizer | This can be done in testing/mozbase/mozrunner/mozrunner/utils.py
[task 2020-10-21T15:22:48.295Z] 15:22:48 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at nsSupportsWeakReference::GetWeakReference, nsBaseCommandController::SetCommandContext, nsGlobalWindowOuter::GetControllersOuter, GetControllers
...
Flags: needinfo?(balbeza)
Pushed by balbeza@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e1c88c0bd854 Part 1: [devtools] Add localStorage resource r=ochameau https://hg.mozilla.org/integration/autoland/rev/31e929a97a3c Part 2: [devtools] Add fission test helpers + a test for localStorage r=jdescottes
Comment 7•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e1c88c0bd854
https://hg.mozilla.org/mozilla-central/rev/31e929a97a3c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Assignee | ||
Updated•4 years ago
|
Flags: needinfo?(balbeza)
You need to log in
before you can comment on or make changes to this bug.
Description
•