Closed
Bug 1666927
Opened 4 years ago
Closed 4 years ago
Unable to tab past keywordoffer results with update2 enabled
Categories
(Firefox :: Address Bar, defect, P1)
Firefox
Address Bar
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox81 | --- | unaffected |
| firefox82 | --- | wontfix |
| firefox83 | --- | fixed |
People
(Reporter: bugzilla, Assigned: bugzilla)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Bug 1657676 changed keywordoffer results to preview search mode when they are selected. That means they show the search mode indicator and clear the Urlbar value. However, this breaks the behaviour changed in bug 1616880, where tab only cycles through results when there's no search string.
We probably just need to update allowTabbingThroughResults to allow tabbing when search mode is active and !!searchMode.isPreview. We should check for isPreview to avoid breaking our a11y tab behaviour when the user is in "full" search mode, blurs the Urlbar with no search string, then refocuses it; in this case, Tab should still move to the next toolbar element.
|
||
Comment 1•4 years ago
|
||
Set release status flags based on info from the regressing bug 1657676
status-firefox81:
--- → unaffected
status-firefox82:
--- → affected
status-firefox83:
--- → affected
status-firefox-esr78:
--- → unaffected
|
||
Updated•4 years ago
|
|
Assignee | |
Updated•4 years ago
|
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 83.1 - Sept 21 - Oct 4
|
|
Assignee | |
Comment 2•4 years ago
|
||
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/680a99a50a1e
Allow tabbing past keywordoffer results with update2 enabled. r=adw
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
|
|
Assignee | |
Updated•4 years ago
|
| Comment hidden (obsolete) |
| Comment hidden (obsolete) |
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•