`DOM_Fullscreen` is not a valid wakelock topic
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: alwu, Assigned: alwu)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
We handle wakelock topic in nsAppShell in each different platform but we didn't handle DOM_Fullscreen, so this wakelock actually didn't take effect.
Someone needs to take a look if we still need this wakelock or not. Currently wakelock would only be correctly request for media playback.
|
||
Updated•4 years ago
|
It seems bug 805017 wanted to use wake lock when using Fullscreen API. But since:
- the spec does not require it
- Chrome does not neither on Android nor Windows
- Gecko also actually didn't
I think we can safely remove it.
|
|
||
Updated•4 years ago
|
There is a suggestion to spec and implement this: https://github.com/whatwg/fullscreen/issues/185
|
Assignee | |
Comment 3•4 years ago
|
||
(In reply to Kagami :saschanaz from comment #1)
It seems bug 805017 wanted to use wake lock when using Fullscreen API. But since:
- the spec does not require it
- Chrome does not neither on Android nor Windows
- Gecko also actually didn't
I think we can safely remove it.
Thank you, I am going to remove this, which can help us to clean unnecessary code for our refactoring preparation. If in the future we still want to add a wakelock for fullscreen, feel free to file another bug and block our meta bug.
|
|
Assignee | |
Comment 4•4 years ago
|
||
Remove this invalid wakelock because our wakelock system doesn't handle this topic.
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
Description
•