Closed Bug 805017 Opened 12 years ago Closed 12 years ago

Disable screen timeout when DOMFullscreen is enabled

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox16 affected, firefox17 affected, fennec18+)

RESOLVED FIXED
Firefox 19
Tracking Status
firefox16 --- affected
firefox17 --- affected
fennec 18+ ---

People

(Reporter: blassey, Assigned: blassey)

References

()

Details

(Whiteboard: [mtd])

Attachments

(1 file)

No description provided.
Attached patch patch (deleted) — Splinter Review
Assignee: nobody → blassey.bugs
Attachment #677364 - Flags: review?(jst)
Does this patch cover the case where we're forced out of full screen mode in some way other than by the setFullScreen(false) being called from JS? I.e. what if I do w = window.open(...), that window ends up in full screen mode, then in the midst of that I call w.close(). Seems we need to do this a bit deeper down in this code, maybe in nsDocument's fullscreen handling code? Cc:ing cpearce as he wrote most of this stuff.
(In reply to Johnny Stenback (:jst, jst@mozilla.com) from comment #2) > Does this patch cover the case where we're forced out of full screen mode in > some way other than by the setFullScreen(false) being called from JS? I think we'll cover those cases. We exit fullscreen (and call nsGlobalWindow::SetFullscreenInternal()) in nsDocument::OnPageHide(), so provided that's called on whatever path we're taking we should be fine. We do this on the close fullscreen window and document navigation cases at least. Brad: Will this patch disable the screen saver on desktop platforms, or do we still need to implement platform specific backends for desktop platforms?
I don't think we have implementations for desktop platforms. Not sure how up to date this is, but it says it isn't planned for desktop or Android [https://wiki.mozilla.org/WebAPI] even though we have an impl for Android.
Attachment #677364 - Flags: review?(jst) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Depends on: 809671
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: