Closed Bug 1668361 Opened 4 years ago Closed 4 years ago

Add support for executing JS shell with self-hosted code loaded from stencil XDR

Categories

(Core :: JavaScript Engine, task, P1)

task

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: djvj, Assigned: nbp)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

Initial steps towards enabling self-hosted code to be loaded from stencil XDR rather than embedded source text.

Adding flag support via the shell will allow us to measure and test the issues with XDR and self-hosted code, and provides a basepoint for further integration.

Assignee: nobody → kvijayan
Status: NEW → ASSIGNED
Severity: -- → N/A
Priority: -- → P1
Assignee: kvijayan → nicolas.b.pierron

This patch improve the speed of the JS Shell loading by 43% in a debug build.
The test suite patch which changes the jit-tests to use this serialization of the self-hosted code goes from 197.6s to 171.2s (~13% improvement for 8087 tests)

Attachment #9188955 - Attachment description: Bug 1668361 - jit-tests: Use XDR to improve the speed of the test suite. [WIP] → Bug 1668361 - JS Shell tests: Use XDR to improve the speed of the test suite.
Attachment #9178828 - Attachment is obsolete: true
Attachment #9178828 - Attachment is obsolete: false
Attachment #9178828 - Attachment is obsolete: true

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:nbp, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(nicolas.b.pierron)
Pushed by npierron@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8b0c716840c4
JS Shell: Use XDR to encode the self-hosted code at runtime. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/f78e99829e26
JS Shell tests: Use XDR to improve the speed of the test suite. r=tcampbell
Flags: needinfo?(nicolas.b.pierron)
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
Regressions: 1686018
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: