Error 'assert test.selfhosted_xdr_mode == "encode"' when running jit-tests with --repeat option
Categories
(Core :: JavaScript Engine, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox84 | --- | unaffected |
firefox85 | --- | unaffected |
firefox86 | --- | fixed |
People
(Reporter: jonco, Assigned: nbp)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
I'm getting an error when I use the --repeat option to jit-tests:
~/work/bug/js/src$ ./jit-test/jit_test.py default-build/shell --repeat 10
Exit code: -11
FAIL - 1659595.js
[ 0| 1| 0| 0] 0% > | 0.0sTraceback (most recent call last):
File "./jit-test/jit_test.py", line 577, in <module>
main(sys.argv[1:])
File "./jit-test/jit_test.py", line 562, in main
ok = jittests.run_tests(job_list, job_count, prefix, options)
File "/Users/jon/work/bug/js/src/tests/lib/jittests.py", line 816, in run_tests
ok = run_tests_local(tests, num_tests, prefix, options, slog)
File "/Users/jon/work/bug/js/src/tests/lib/jittests.py", line 859, in run_tests_local
ok = process_test_results(gen, num_tests, pb, options, slog)
File "/Users/jon/work/bug/js/src/tests/lib/jittests.py", line 745, in process_test_results
for i, res in enumerate(results):
File "/Users/jon/work/bug/js/src/tests/lib/tasks_unix.py", line 286, in run_all_tests
assert test.selfhosted_xdr_mode == "encode"
AssertionError
This seems to have been introduced by bug 1668361.
Assignee | ||
Comment 1•4 years ago
|
||
I will investigate tomorrow, in the mean time you should be able to use the repeat option by disabling this optimization with --no-xdr
jit-test option.
Comment 2•4 years ago
|
||
Set release status flags based on info from the regressing bug 1668361
Updated•4 years ago
|
Assignee | ||
Comment 3•4 years ago
|
||
The repeat option of jit_tests.py
was interpreted as a plain copy of the
object pointer. Therefore the xdr_annotate
function, first annotated the first
test with an encode
mode for the self hosted code, but later overwrote it with
decode
as the rests of the tests are annotated to make use of the serialized
self hosted stencil.
This change make use of the copy
function of the test class to avoid sharing
the same instance between the first run and subsequent runs.
Updated•4 years ago
|
Updated•4 years ago
|
Comment 5•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Description
•