Add test about search mode and one-off button behavior when typing search engine alias after selecting one of one-off button.
Categories
(Firefox :: Address Bar, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: daisuke, Assigned: daisuke)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
This is a follow-up of bug 1665908.
As Marco advised in phabricator, we should test about search mode and one-off button behavior when typing search engine alias after selecting one of one-off button into browser_searchMode_alias_replacement.js.
The test case Marco suggested is following:
- Select one of one-off button
- Type a valid alias (like "@alias sometext")
Then, check it is not converted into a different search mode and one-off button is still selected.
|
Assignee | |
Comment 1•4 years ago
|
||
(In reply to Daisuke Akatsuka (:daisuke) from comment #0)
The test case Marco suggested is following:
- Select one of one-off button
- Type a valid alias (like "@alias sometext")
Then, check it is not converted into a different search mode and one-off button is still selected.
One thing.
The above test works for current m-c. But, if we apply a patch of bug 1665908, the last assertion (one-off button is still selected) would be failed since one-off button will be unselected whenever entering search mode.
So, Assuming that the patch of bug 1665908 is applied, add the test.
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D91393
|
||
Updated•4 years ago
|
| Comment hidden (obsolete) |
|
|
||
Comment 4•4 years ago
|
||
Ah, I see what you mean, when we start typing we confirm search mode and that clears the one-off.
Thanks for pointing that out.
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
Description
•