Closed
Bug 1670343
Opened 4 years ago
Closed 4 years ago
add a few weak frame checks after bug 1651332
Categories
(Core :: Panning and Zooming, defect)
Core
Panning and Zooming
Tracking
()
RESOLVED
FIXED
83 Branch
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: tnikkel, Assigned: tnikkel)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
Bug 1651332 added a UpdateScrollbarPosition call to SetVisualViewportOffset. UpdateScrollbarPosition calls are surrounded by weak frame checks from bug 898871. These may not be needed anymore, the stacks from bug 898871 might be impossible now, but I'm not sure, so I'll just add the weak frame checks etc here.
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Updated•4 years ago
|
Keywords: leave-open
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/725180017480
Call SetVisualViewportOffset after nsHTMLScrollFrame::Reflow so we can add a weak frame check around it. r=kats
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•4 years ago
|
Keywords: leave-open
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e528f398e166
Re-get the frame in ScrollFrame in APZCCallbackHelper after calling SetVisualViewportOffset. r=kats
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox83:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
Keywords: regression
|
||
Updated•3 years ago
|
Type: task → defect
You need to log in
before you can comment on or make changes to this bug.
Description
•