Closed Bug 1753374 Opened 3 years ago Closed 3 years ago

don't allow pending vv offset updates to become the vv offset purely on the content side without asking apz

Categories

(Core :: Panning and Zooming, defect, P3)

Product:
Core
Component:
Panning and Zooming
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
99 Branch
Tracking Flags:
Tracking Status
firefox99 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file)

Bug 1753374. Don't allow pending vv offset updates to become the vv offset purely on the content side without asking apz. r?botond
(deleted), text/x-phabricator-request
Details
No description provided.

ScrollFrameHelper::GetVisualViewportOffset will return a pending vv offset if there is one. So if there is a pending vv offset this line will instantly turn it into the current vv offset. This is not how the pending vv offset is supposed to work. It should get sent over to apz, apz can then decide to accept or reject it based on whether it knows about user scrolling that overrides it.

I saw this while reading code for something else, so I don't know of anything specific this fixes.

Depends on D137720

Assignee: nobody → tnikkel
Status: NEW → ASSIGNED
Depends on: 1670343
Depends on: 1753372
Severity: -- → S3
Priority: -- → P3
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/acd31d1d0fce Don't allow pending vv offset updates to become the vv offset purely on the content side without asking apz. r=botond

https://hg.mozilla.org/mozilla-central/rev/acd31d1d0fce

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox99: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: