Closed Bug 1674761 Opened 4 years ago Closed 4 years ago

Add a shell flag for enabling large ArrayBuffers

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Regressed 1 open bug)

Details

Attachments

(4 files)

We should add a shell flag for bumping the max ArrayBuffer/TypedArray size on 64-bit platforms. We can then add some smoke tests to ensure the work that landed so far doesn't regress.

Preparation for making the max length depend on a shell flag or browser pref.

Change static_assert in EmitDataViewBoundsCheck to a MOZ_ASSERT. This function still
needs to be fixed.

Depends on D95521

Similar to the previous patch. Two places where JIT code used a static_assert now use
a MOZ_ASSERT and will need additional work.

Depends on D95522

For now run tests with --no-blinterp because JIT support needs more work.

Depends on D95523

Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6fa41dcd00b8
part 1 - Add a MaxMemory32Bytes constant and use it instead of MaxBufferByteLength in a few places. r=lth
https://hg.mozilla.org/integration/autoland/rev/a778c4ba3df8
part 2 - Replace MaxBufferByteLength constant with a function. r=lth,sfink
https://hg.mozilla.org/integration/autoland/rev/d4f24d61a414
part 3 - Replace typed array MAX_BYTE_LENGTH constant with a function. r=sfink
https://hg.mozilla.org/integration/autoland/rev/6d094ce04a5d
part 4 - Add a shell flag and some tests for large ArrayBuffers and typed arrays. r=sfink,lth
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: