Closed
Bug 1677427
Opened 4 years ago
Closed 4 years ago
remove <grid> usage from openpgp
Categories
(MailNews Core :: Security: OpenPGP, task, P1)
MailNews Core
Security: OpenPGP
Tracking
(thunderbird_esr78 wontfix, thunderbird85 wontfix)
RESOLVED
FIXED
85 Branch
People
(Reporter: mkmelin, Assigned: khushil324)
References
Details
Attachments
(1 file, 4 obsolete files)
(deleted),
patch
|
khushil324
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1521483 +++
There's still a small amount of <grid> in the openpgp code: https://searchfox.org/comm-central/search?q=enigmailKeyImportInfo.js&path=mail&case=false®exp=false
It's also apparently using top level <dialog>...
The dialog is pretty horrible, so we could try to fix the appearance at least a bit while we're here.
<grid> will very soon be removed from m-c now.
Assignee | ||
Updated•4 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•4 years ago
|
||
Attachment #9188976 -
Attachment is obsolete: true
Attachment #9188976 -
Flags: review?(mkmelin+mozilla)
Attachment #9188983 -
Flags: review?(mkmelin+mozilla)
Assignee | ||
Comment 3•4 years ago
|
||
Attachment #9188983 -
Attachment is obsolete: true
Attachment #9188983 -
Flags: review?(mkmelin+mozilla)
Attachment #9188987 -
Flags: review?(mkmelin+mozilla)
Reporter | ||
Comment 4•4 years ago
|
||
Comment on attachment 9188987 [details] [diff] [review] Bug-1677427_remove-grid-openpgp-2.patch Review of attachment 9188987 [details] [diff] [review]: ----------------------------------------------------------------- The title "Success! Keys imported" is no longer set. Other than that, this whole dialog is so strange and confusing I don't even know where to begin... but that's out of scope for this bug. ::: mail/extensions/openpgp/content/ui/enigmailKeyImportInfo.js @@ +69,4 @@ > > if (keys.length) { > let keysInfoBox = document.getElementById("keyInfo"), > + keyBox = document.createXULElement("vbox"); please declare each separeately, not with commas @@ +73,3 @@ > > + keyBox.classList.add("grid-three-column"); > + for (i = 0; i < keys.length; i++) { would declare i here, but even better use for (let key of keys) @@ +125,1 @@ > for (i = 0; i < keyObj.fpr.length; i += 4) { declare i here in the loop ::: mail/themes/shared/openpgp/enigmail-common.css @@ +89,4 @@ > border-style: groove; > border-width: thin; > padding: 3px; > + margin: 10px 3px; also afffecting enigmailKeygen.xhtml. Not sure we want that
Attachment #9188987 -
Flags: review?(mkmelin+mozilla)
Assignee | ||
Comment 5•4 years ago
|
||
Attachment #9188987 -
Attachment is obsolete: true
Attachment #9189129 -
Flags: review?(mkmelin+mozilla)
Reporter | ||
Comment 6•4 years ago
|
||
Comment on attachment 9189129 [details] [diff] [review] Bug-1677427_remove-grid-openpgp-3.patch Review of attachment 9189129 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/extensions/openpgp/content/ui/enigmailKeyImportInfo.xhtml @@ +21,3 @@ > xmlns:html="http://www.w3.org/1999/xhtml"> > +<dialog id="enigmailKeyImportInfo" > + buttons="accept,help,cancel,extra1,extra2"> ok so we only ever use accept, and manually hide all the others, never to be shown. Maybe we can fix that while we're here.
Attachment #9189129 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Comment 7•4 years ago
|
||
Attachment #9189129 -
Attachment is obsolete: true
Attachment #9189146 -
Flags: review+
Assignee | ||
Updated•4 years ago
|
Keywords: checkin-needed-tb
Reporter | ||
Updated•4 years ago
|
status-thunderbird85:
--- → wontfix
status-thunderbird_esr78:
--- → wontfix
Target Milestone: --- → 85 Branch
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/2bfa9ffc8c69
Remove grid usage from openpgp. r=mkmelin
You need to log in
before you can comment on or make changes to this bug.
Description
•