Closed
Bug 167866
Opened 22 years ago
Closed 22 years ago
clean up comment line codes for nsPresShell.cpp
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: masaki.katakai, Assigned: masaki.katakai)
Details
Attachments
(1 file)
|
(deleted),
patch
|
akkzilla
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
While bugfixing of bug 52416, we found some codes are commented
out in PresShell::HandleEvent() of
layout/html/base/src/nsPresShell.cpp
and it's hard for developper to understand the codes.
We need to clean up the codes.
Saari, please give your suggestion or take this.
Thank you.
|
Assignee | |
Comment 1•22 years ago
|
||
I simply removed all comments and commented codes because all comments
are for the commented codes. The comments of first part is about
GetFrameForPoint(),
also XP_MAC is commented out, so I removed the comments about Mac.
|
|
Assignee | |
Comment 2•22 years ago
|
||
Hi Akkana,
Can you please review the patch ?
Thank you.
Status: NEW → ASSIGNED
|
||
Comment 3•22 years ago
|
||
Comment on attachment 100879 [details] [diff] [review]
patch
r=akkana, and sorry I took so long!
Attachment #100879 -
Flags: review+
|
|
Assignee | |
Comment 4•22 years ago
|
||
Thanks, Akkana.
Asking sr= now.
Comment on attachment 100879 [details] [diff] [review]
patch
sr=roc+moz
Attachment #100879 -
Flags: superreview+
|
|
Assignee | |
Comment 6•22 years ago
|
||
Thank you very much for r= and sr=.
I'll check-in after 1.2final.
|
|
Assignee | |
Comment 7•22 years ago
|
||
checked in to Trunk.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•