Add a common API for all DNS resolvers.
Categories
(Core :: Networking: DNS, task, P3)
Tracking
()
People
(Reporter: valentin, Unassigned)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Whiteboard: [necko-triaged])
Attachments
(4 obsolete files)
Similar to how TRRQuery works, all the resolvers should share a common API
- TRRQuery, UDPResolver and GetAddrInfo should implement a common interface.
- TRRQuery, UDPResolver can additionally share some code via a base class.
- We should get rid of
network.trr.early-AAAA
(andnetwork.trr.wait-for-A-and-AAAA
since it doesn't control anything) and enforce that we only get oneCompleteLookup
call per request
Reporter | ||
Comment 1•4 years ago
|
||
Calling c->remove() will remove the entry from rec->mCallbacks and could
potentially release the object (if this is the last reference).
While unlikely, it's best to avoid this corner case.
Reporter | ||
Comment 2•4 years ago
|
||
These prefs were mostly a perf improvement - return the first address family
first then merge the result with the other family.
However, this turned out to cause intermittent issues on some sites, so it
was turned off by default.
Removing these prefs allows us to have the same functionality across all
our resolvers - one request means one callback after both A and AAAA responses
have been received.
Depends on D99756
Reporter | ||
Comment 3•4 years ago
|
||
These types got changed in bug 1678299.
Going forward it's important to have them match up.
Depends on D99757
Reporter | ||
Comment 4•4 years ago
|
||
Depends on D99758
Comment 5•4 years ago
|
||
Comment on attachment 9193195 [details]
Bug 1681149 - Hold a strong ref to the nsResolveHostCallback r=#necko
Revision D99756 was moved to bug 1691721. Setting attachment 9193195 [details] to obsolete.
Comment 6•4 years ago
|
||
Comment on attachment 9193196 [details]
Bug 1681149 - Remove early partial DNS records prefs r=#necko
Revision D99757 was moved to bug 1691721. Setting attachment 9193196 [details] to obsolete.
Comment 7•4 years ago
|
||
Comment on attachment 9193199 [details]
Bug 1681149 - Add DNSPacket::GetRCode and remove TRRSkippedReason argument r=#necko
Revision D99760 was moved to bug 1691721. Setting attachment 9193199 [details] to obsolete.
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Description
•