Closed Bug 1691721 Opened 4 years ago Closed 4 years ago

Clean up some DNS code

Categories

(Core :: Networking: DNS, task, P2)

task

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: valentin, Assigned: valentin)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [necko-triaged])

Attachments

(3 files)

No description provided.

Calling c->remove() will remove the entry from rec->mCallbacks and could
potentially release the object (if this is the last reference).
While unlikely, it's best to avoid this corner case.

These prefs were mostly a perf improvement - return the first address family
first then merge the result with the other family.
However, this turned out to cause intermittent issues on some sites, so it
was turned off by default.
Removing these prefs allows us to have the same functionality across all
our resolvers - one request means one callback after both A and AAAA responses
have been received.

Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/3aeae9aca54c Hold a strong ref to the nsResolveHostCallback r=necko-reviewers,kershaw https://hg.mozilla.org/integration/autoland/rev/6d20e26ab118 Remove early partial DNS records prefs r=necko-reviewers,kershaw https://hg.mozilla.org/integration/autoland/rev/0d11fea55ee9 Add DNSPacket::GetRCode and remove TRRSkippedReason argument r=necko-reviewers,kershaw
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: