Closed Bug 1684366 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 27015 - [selectors] Add new test for :focus-visible

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox87 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27015 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27015
Details from upstream follow.

b'Manuel Rego Casasnovas <rego@igalia.com>' wrote:

[selectors] Add new test for :focus-visible

This test checks that when you click an element to focus it,
it doesn't show any kind of focus ring. See issue #4278.

Currently Firefox passes this test, by Chromium fails it
because Chromium is using :focus on the default UA stylesheet
and is adding an outline on the element, despite it doesn't match
:focus-visible (see https://crbug.com/1162070).

PR 27015 applied with additional changes from upstream: ccaf4599f0d853985bfb19fb87cfac20f0597308
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 2 subtests

Status Summary

Firefox

OK : 2
PASS: 3
FAIL: 1

Chrome

OK : 2
PASS: 3
FAIL: 1

Safari

OK : 2
PASS: 1
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/selectors/focus-visible-017.html
By default initial programatic focus matches ':focus-visible', so the element shows a focus ring with 'outline-style: auto': FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/990ee1b12d5a [wpt PR 27015] - [selectors] Add tests for :focus-visible in the default UA style sheet, a=testonly https://hg.mozilla.org/integration/autoland/rev/86325097d151 [wpt PR 27015] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/990ee1b12d5a
https://hg.mozilla.org/mozilla-central/rev/86325097d151

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.