Closed Bug 1688533 Opened 4 years ago Closed 2 years ago

Consider changing the default `:focus-visible` outline from `1px dotted` to `auto` [was: New wpt failures in /css/selectors/focus-visible-017.html]

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1759602

People

(Reporter: mozilla.org, Unassigned)

References

Details

(Whiteboard: [wpt])

Syncing wpt PR 27015 found new untriaged test failures in CI

Tests Affected

New Tests That Don't Pass

/css/selectors/focus-visible-017.html
By default initial programatic focus matches ':focus-visible', so the element shows a focus ring with 'outline-style: auto': FAIL (Chrome: PASS, Safari: FAIL)

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1684366 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Changing this to auto (it's now moved to ua.css, fwiw) would be a significant visual change in some cases.

On macOS, at least, the result would be more similar to what I see in Safari and Chrome (though whether that's desirable could be up for debate). I haven't looked into the effect on other platforms at this point.

Severity: -- → S3
Summary: New wpt failures in /css/selectors/focus-visible-017.html → Consider changing the default `:focus-visible` outline from `1px dotted` to `auto` [was: New wpt failures in /css/selectors/focus-visible-017.html]

(In reply to Jonathan Kew (:jfkthame) from comment #2)

Changing this to auto (it's now moved to ua.css, fwiw) would be a significant visual change in some cases.

Looks like we made this change (to auto) in bug 1759602, and we were able to remove the failure annotation for this test in that bug's commit:
https://hg.mozilla.org/mozilla-central/rev/657571013f20bfb5942ed5293118c4226de12aef#l5.2

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.