Closed Bug 1685564 Opened 4 years ago Closed 4 years ago

The texture cache textures are too small because of broken "Main window" detection

Categories

(Core :: Graphics: WebRender, defect)

Product:
Core
Component:
Graphics: WebRender
Platform:
All
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox84 --- unaffected
firefox85 --- unaffected
firefox86 + fixed

People

(Reporter: mstange, Assigned: mstange)

References

(Regression)

Details

(Keywords: perf, regression)

Attachments

(1 file)

Bug 1685564 - Check for popup widgets instead of toplevel widgets. r=nical
(deleted), text/x-phabricator-request
Details

Bug 1624264 added adaptive texture cache texture sizes based on the window type. However, the widget that we're calling WindowType on is a child widget, and not the outer window widget. As a result, at least on macOS, we're always using the small texture sizes now.

[Tracking Requested - why for this release]: Regression which causes bad WebRender performance on macOS

tracking-firefox86: --- → ?

Popup widgets are easier to detect because the "window" widget and the "view"
widget for them are the same object.
With toplevel widgets, most platforms (IIRC all non-Windows platforms) have
separate nsIWidget objects for the "window" widget (toplevel) and the "view"
widget (child), and this code has a reference to the view / child widget.

Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/e066d5e8974d Check for popup widgets instead of toplevel widgets. r=nical

https://hg.mozilla.org/mozilla-central/rev/e066d5e8974d

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox86: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: