Refactor tests using the storage actor directly to use it via resourceWatcher.watchResources([STORAGE_TYPES...])
Categories
(DevTools :: Storage Inspector, task, P3)
Tracking
(Fission Milestone:M8, firefox91 fixed)
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Regressed 1 open bug)
Details
(Whiteboard: dt-fission-m3-mvp)
Attachments
(5 files)
Bug 1644192 dependencies are going to make the storage actor unused by DevTools frontend. Only tests and may be some external tools using RDP may be using this old codepath.
devtools/server/actor/storage.js will still be used via storage Watcher classes, but no longer as a target-scoped actor.
We should refactor the tests in order to cover the new codepath, using ResourceWatcher API.
i.e. resourceWatcher.watchResources([STORAGE_TYPES...])
"STORAGE_TYPES..." will be COOKIE, INDEXEDDB, LOCAL_STORAGE, ...
I think that's only these 6 tests:
https://searchfox.org/mozilla-central/search?q=listStores%28%29&path=&case=false®exp=false
Note that all storage panel tests should be using the panel code and so the ResourceWatcher codepath. Here we only have to refactor tests manually querying the storage front.
|
||
Comment 1•4 years ago
|
||
Tracking dt-fission-m3-mvp bugs for Fission M7 (blocking Beta experiment).
|
||
Updated•4 years ago
|
|
|
||
Comment 2•4 years ago
|
||
Tracking dt-fission-m3-mvp test and infrastructure bugs for Fission M8 (blocking Release experiment).
|
|
||
Comment 3•4 years ago
|
||
Tracking DevTools Post-M8 bugs for Fission MVP milestone. They don't block the Fission Release channel experiment, but we would like them to be completed before we roll out Fission by default.
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
Assignee | |
Comment 4•3 years ago
|
||
We should stop using StorageActor.listStores in favor of ResourceCommand.
listStores still forces to involve message manager in the server codebase.
This breaks when we enable JSWindowActor based targets.
|
|
Assignee | |
Comment 5•3 years ago
|
||
We should stop using StorageActor.listStores in favor of ResourceCommand.
listStores still forces to involve message manager in the server codebase.
This breaks when we enable JSWindowActor based targets.
|
|
Assignee | |
Comment 6•3 years ago
|
||
We should stop using StorageActor.listStores in favor of ResourceCommand.
listStores still forces to involve message manager in the server codebase.
This breaks when we enable JSWindowActor based targets.
|
|
Assignee | |
Comment 7•3 years ago
|
||
We should stop using StorageActor.listStores in favor of ResourceCommand.
listStores still forces to involve message manager in the server codebase.
This breaks when we enable JSWindowActor based targets.
|
|
Assignee | |
Comment 8•3 years ago
|
||
This test is not relevant in fission as we aren't using listStores,
nor do we have any EXTENSION_STORAGE resource to test yet.
|
|
Assignee | |
Comment 9•3 years ago
|
||
A green (enough) try run for these patches:
https://treeherder.mozilla.org/jobs?repo=try&revision=9a42e6c7e69ecfa20da64d2747edf899e6376f8a
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
||
Comment 10•3 years ago
|
||
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bcb1103c708d [devtools] Migrate browser_storage_updates to ResourceCommand. r=ladybenko https://hg.mozilla.org/integration/autoland/rev/6f5900fd6c02 [devtools] Migrate browser_storage_listing to ResourceCommand. r=ladybenko https://hg.mozilla.org/integration/autoland/rev/f59fc0817dd9 [devtools] Migrate browser_storage_cookies-duplicate-names to ResourceCommand. r=ladybenko https://hg.mozilla.org/integration/autoland/rev/5a4f2fe5ee61 [devtools] Disable browser_storage_webext_storage_local on fission. r=ladybenko https://hg.mozilla.org/integration/autoland/rev/c9d6f02ad2f6 [devtools] Migrate browser_storage_dynamic_windows to ResourceCommand. r=ladybenko
|
||
Comment 11•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bcb1103c708d
https://hg.mozilla.org/mozilla-central/rev/6f5900fd6c02
https://hg.mozilla.org/mozilla-central/rev/f59fc0817dd9
https://hg.mozilla.org/mozilla-central/rev/5a4f2fe5ee61
https://hg.mozilla.org/mozilla-central/rev/c9d6f02ad2f6
Description
•