Closed
Bug 1686936
Opened 4 years ago
Closed 4 years ago
Make more typed array code work with large buffers
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
86 Branch
| Tracking | Status | |
|---|---|---|
| firefox86 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(13 files, 1 obsolete file)
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details |
No description provided.
|
Assignee | |
Updated•4 years ago
|
Severity: normal → N/A
Priority: -- → P3
|
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
Merges the self-hosted code and C++ intrinsic and also adds support for
large buffers.
This follows the old code because the current spec looks pretty different.
Depends on D101922
|
|
Assignee | |
Updated•4 years ago
|
Keywords: leave-open
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3e922579936a part 1 - Make %TypedArray%.prototype.set work with large buffers. r=anba https://hg.mozilla.org/integration/autoland/rev/fb62a5b51d3c part 2 - Port %TypedArray%.prototype.copyWithin to C++. r=anba
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 5•4 years ago
|
||
To support lengths > INT32_MAX.
The JITs will need additional changes later on.
|
|
Assignee | |
Comment 6•4 years ago
|
||
Depends on D102145
|
|
Assignee | |
Comment 7•4 years ago
|
||
Depends on D102146
|
|
Assignee | |
Comment 8•4 years ago
|
||
Depends on D102147
|
|
Assignee | |
Comment 9•4 years ago
|
||
Both |begin| and |end| are uint32_t so we can just compare to size_t.
Depends on D102148
|
|
Assignee | |
Comment 10•4 years ago
|
||
Depends on D102149
|
|
Assignee | |
Comment 11•4 years ago
|
||
Depends on D102150
|
|
Assignee | |
Comment 12•4 years ago
|
||
|
||
Updated•4 years ago
|
Attachment #9197694 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 13•4 years ago
|
||
|
|
Assignee | |
Comment 14•4 years ago
|
||
Depends on D102266
|
|
Assignee | |
Comment 15•4 years ago
|
||
|
|
Assignee | |
Comment 16•4 years ago
|
||
Note that the union needs the explicit constructor now because BufferSize has one.
Depends on D102268
|
||
Comment 17•4 years ago
|
||
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1108b34b936d part 3 - Clean up setNumber/NumberValue implementations in Value.h. r=anba,tcampbell
|
|
||
Comment 18•4 years ago
|
||
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5d3476403514 part 4 - Make TypedArrayBitwiseSlice work with large buffers. r=anba https://hg.mozilla.org/integration/autoland/rev/025ee8bfc497 part 5 - Make ensureHasBuffer and objectMoved work with large buffers. r=anba https://hg.mozilla.org/integration/autoland/rev/ad668d21ceee part 6 - Make some iteration code work with large buffers. r=anba https://hg.mozilla.org/integration/autoland/rev/e881cca27ae7 part 7 - Make GetIndexedPropertiesInRange work with large buffers. r=anba https://hg.mozilla.org/integration/autoland/rev/c38fe897cf35 part 8 - Make IsBufferSource work with large buffers. r=anba https://hg.mozilla.org/integration/autoland/rev/65b3f11c33a3 part 9 - Make GetElements work with large buffers. r=anba
|
|
||
Comment 19•4 years ago
|
||
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e83fde9d2053 part 10 - Make PossiblyWrappedTypedArrayLength work with large buffers. r=anba https://hg.mozilla.org/integration/autoland/rev/d93a7a7cab2b part 11 - Make {Shared}ArrayBufferSlice work with large buffers. r=anba https://hg.mozilla.org/integration/autoland/rev/60ca56bbe3f6 part 12 - Make CacheEntry_getBytecode work with large buffers. r=anba https://hg.mozilla.org/integration/autoland/rev/3c7764105a39 part 13 - Make SharedObjectMailbox work with large buffers. r=lth
|
|
Assignee | |
Updated•4 years ago
|
Keywords: leave-open
|
||
Comment 20•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1108b34b936d
https://hg.mozilla.org/mozilla-central/rev/5d3476403514
https://hg.mozilla.org/mozilla-central/rev/025ee8bfc497
https://hg.mozilla.org/mozilla-central/rev/ad668d21ceee
https://hg.mozilla.org/mozilla-central/rev/e881cca27ae7
https://hg.mozilla.org/mozilla-central/rev/c38fe897cf35
https://hg.mozilla.org/mozilla-central/rev/65b3f11c33a3
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox86:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
|
|
||
Comment 21•4 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•