Closed
Bug 1687659
Opened 4 years ago
Closed 4 years ago
jit-tests --repeat option doesn't have any effect
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
86 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox84 | --- | unaffected |
| firefox85 | --- | unaffected |
| firefox86 | --- | fixed |
People
(Reporter: jonco, Assigned: nbp)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Since bug 1686272, the --repeat option no longer raises an exception, but it doesn't repeat the tests either.
~/work/dev/js/src$ jit-test/jit_test.py optdebug-build/shell incremental-abort --repeat 100
[ 1| 0| 0| 0] 100% ==================================================>| 0.9s
PASSED ALL
|
||
Comment 1•4 years ago
|
||
Set release status flags based on info from the regressing bug 1686272
status-firefox84:
--- → unaffected
status-firefox85:
--- → unaffected
status-firefox86:
--- → affected
status-firefox-esr78:
--- → unaffected
|
Assignee | |
Comment 2•4 years ago
|
||
When using the options.repeat, we consume the job_list generator, which
causes it to be empty on the next iteration. This patch forces the content of
the generator to be stored in a list before iterating over it multiple times.
|
||
Updated•4 years ago
|
Assignee: nobody → nicolas.b.pierron
Status: NEW → ASSIGNED
Pushed by npierron@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d38c704c37ca
jit_test.py: repeat_copy is now aware of generators. r=jonco
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
|
|
||
Updated•4 years ago
|
Keywords: regression
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•