Closed Bug 1690134 Opened 4 years ago Closed 4 years ago

Intermittent in browser_history_persist.js (wrong URL: got about:blank, should be about:robots) in fission

Categories

(Core :: DOM: Navigation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
90 Branch
Fission Milestone M7a
Tracking Status
firefox-esr78 --- unaffected
firefox85 --- unaffected
firefox86 --- unaffected
firefox87 --- disabled
firefox88 --- disabled
firefox89 --- disabled
firefox90 --- fixed

People

(Reporter: jesup, Assigned: u608768)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Bug 1673617 causes a new intermittent in fission only, where the URL is incorrect occasionally (~30% on Try, <1% locally).

TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_history_persist.js | Should be the right URL - Got "about:blank", expected "about:robots"
often but not always followed by:
TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_history_persist.js | Should be two history entries - Got 1, expected 2
TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_history_persist.js | Uncaught exception - [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsISHistory.getEntryAtIndex]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_history_persist.js :: check_history_default_persisted :: line 155" data: no]
TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_history_persist.js | Found an unexpected tab at the end of test run: about:blank -

Set release status flags based on info from the regressing bug 1673617

Tracking for Fission M7 for re-enabling this test.

https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/browser/components/sessionstore/test/browser.ini#115-116

[browser_history_persist.js]
skip-if = fission # Bug 1690134
Fission Milestone: ? → M7
Severity: -- → S3
Priority: -- → P3

I'm taking a look at this, though I'm not familiar with session store.

Assignee: nobody → continuation

It sounds like this might be fixed by Kashav and Andreas's work on session restore, so I'll assign it to Kashav for enabling.

Assignee: continuation → kmadan

Will enable this in bug 1597499.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE

Happening again, particularly often with the patches from bug 1702055. I think I have a fix.

Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---

Waiting for the about:robots load explicitly ensures we don't proceed until all
history changes have fully propagated.

Pushed by kmadan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/252f1d727e0d Fix flakiness in browser_history_persist.js, r=annyG
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: