Update focused-and-closed state
Categories
(Firefox :: Address Bar, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox88 | --- | verified |
People
(Reporter: bugzilla, Assigned: bugzilla)
References
(Blocks 1 open bug)
Details
(Keywords: blocked-ux, Whiteboard: [proton-address-bar])
Attachments
(2 files)
We're adding a 2px border and a new drop-shadow. We may need to review animations. We should also check that prefers-reduced-motion still behaves as expected, so we don't regress bug 1629303. To check with UX: will we be following system colours for the border, or will it be blue for all users?
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
To answer the question in comment 0, the border will be blue for all users.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
This patch mainly does three things:
- Changes the necessary CSS to meet the Proton spec.
- Removes several calls to UrlbarInput.startLayoutBreakout(), because the Urlbar no longer eexpands when the panel is not open.
- Introduces a [suppress-focus-border] attribute. This attribute hides the 2px focus ring around the Urlbar. This ensures that we don't flash the focus ring when the user clicks a Urlbar that will autoOpen, seeing as the open Urlbar no longer has a border. It also hides the focus border after the user presses Esc, as specified in Figma.
Assignee | ||
Comment 3•4 years ago
|
||
Dao points out at https://phabricator.services.mozilla.com/D105097#inline-590409 that prefers-contrast is not adequate when accounting for various Linux OS themes. We have to use the OS accent color on Linux if we want to maintain compatibility with OS themes. This follows not supporting the new color for the unfocused Urlbar on Linux (see D104898) and not supporting the grey result-highlight colour on Linux (see D105535). We should change focus-outline-color universally on Linux for the same reasons.
Updated•4 years ago
|
Comment 5•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c42d19253920
https://hg.mozilla.org/mozilla-central/rev/f124983faac7
Comment 6•4 years ago
|
||
We verified this issue using Fx 88.0b5 on Windows 10 x64, macOS 10.13 and Ubuntu 18.04 LTS.
Description
•