Closed
Bug 1692162
Opened 4 years ago
Closed 4 years ago
Support larger buffers in TypedArray.prototype.subarray
Categories
(Core :: JavaScript: Standard Library, task)
Core
JavaScript: Standard Library
Tracking
()
RESOLVED
FIXED
87 Branch
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The TypedArraySubarray self-hosted function uses a left-shift operation, which restricts the byte-offset variable to int32, but for large buffers the offset can be larger than int32.
|
Assignee | |
Comment 1•4 years ago
|
||
Replace the left-shift with a multiplication to support non-int32 values.
Renames the existing TypedArrayElementShift helper with TypedArrayElementSize
throughout the code base. TypedArrayElementSize returns the element size, so
we can directly use it in multiplications.
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/3d4734278d27 Support large buffers in TypedArray.prototype.subarray(). r=jandem
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•