Closed
Bug 1692961
Opened 4 years ago
Closed 4 years ago
Always set BCTargetActor isTopLevelTarget via a constructor option
Categories
(DevTools :: Framework, task, P3)
DevTools
Framework
Tracking
(firefox87 fixed)
RESOLVED
FIXED
87 Branch
Tracking | Status | |
---|---|---|
firefox87 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
With the initial implementation in Bug 1690698, some BrowsingContextTargetActor classes (eg webextension & parent process) automatically pass isTopLevelTarget: true when calling BrowsingContextTargetActor::initialize. While this is ok for now, in the future we might want to spawn webextension targets within a parent process debugging session and such a target should not be flagged as top level.
Therefore we should always pass isTopLevelTarget as an explicit constructor argument.
Also, it could be an occasion to settle on a consistent constructor signature:
BrowsingContextTargetActor(conn, options)
Assignee | ||
Comment 1•4 years ago
|
||
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/20f12466d1f2 [devtools] Explicitly pass isTopLevelTarget as an option to all BrowsingContextTargetActor r=ochameau
Comment 3•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox87:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•