Allow to set configuration flags via the DevTools watcher
Categories
(DevTools :: Framework, task, P3)
Tracking
(Fission Milestone:M7, firefox87 fixed)
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 4 open bugs)
Details
(Whiteboard: dt-fission-m3-mvp)
Attachments
(7 files, 1 obsolete file)
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details |
We should leverage the watcher in order to set configuration flags that apply to the whole devtools session.
Example usage:
- preferences read on the client but that also have an impact on the server (eg the server target switching pref for Bug 1644397)
- settings currently set via target::reconfigure (cacheDisabled, ...)
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
Commented, thanks for the the heads up!
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 3•4 years ago
|
||
|
|
Assignee | |
Comment 4•4 years ago
|
||
This flag will be needed for server side target switching as well.
Introducing it here will allow to update the configuration only on top level targets
|
|
Assignee | |
Comment 5•4 years ago
|
||
Depends on D104392
|
|
Assignee | |
Comment 6•4 years ago
|
||
Depends on D104392
With the Configuration actor the javascript enabled information should no longer be held by the target front.
This abstraction layer in target-list will make the transition easier.
|
|
Assignee | |
Comment 7•4 years ago
|
||
Depends on D104423
|
|
Assignee | |
Comment 8•4 years ago
|
||
Depends on D104394
|
|
Assignee | |
Comment 9•4 years ago
|
||
Depends on D104429
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 10•4 years ago
|
||
Depends on D104424
performReload is not a regular configuration option as it is not persisted.
It is rather a flag for a single call to Target::reconfigure.
As we move configuration options outside of the target, it will be easier to drive the reload from the frontend.
The call sites using performReload are quite rare and only found in the netmonitor so it doesn't feel like this
requires a framework solution for now. We add explicit calls to TargetFront::reload() in spots where the netmonitor
used to pass performReload = true.
|
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
||
Comment 11•4 years ago
|
||
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2b8dc733141d [devtools] Remove unused reconfigure trait r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/04398ec69bcf [devtools] Add isTopLevelTarget flag on target actors r=ochameau https://hg.mozilla.org/integration/autoland/rev/07a143d7c32a [devtools] Expose isJavascriptEnabled API on TargetList r=ochameau,bomsy https://hg.mozilla.org/integration/autoland/rev/a1b18b5de236 [devtools] Move calls to reconfigure behind TargetList::updateConfiguration r=ochameau,bomsy https://hg.mozilla.org/integration/autoland/rev/b39b60e8120d [devtools] Remove performReload option and call reload from the frontend r=ochameau,bomsy,devtools-backward-compat-reviewers https://hg.mozilla.org/integration/autoland/rev/a66579c7109a [devtools] Introduce a watcher TargetConfiguration actor r=ochameau,bomsy,devtools-backward-compat-reviewers https://hg.mozilla.org/integration/autoland/rev/a5d53c7b02b4 [devtools] Add a test for the watcher TargetConfiguration actor r=bomsy,ochameau
|
||
Comment 12•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2b8dc733141d
https://hg.mozilla.org/mozilla-central/rev/04398ec69bcf
https://hg.mozilla.org/mozilla-central/rev/07a143d7c32a
https://hg.mozilla.org/mozilla-central/rev/a1b18b5de236
https://hg.mozilla.org/mozilla-central/rev/b39b60e8120d
https://hg.mozilla.org/mozilla-central/rev/a66579c7109a
https://hg.mozilla.org/mozilla-central/rev/a5d53c7b02b4
|
||
Comment 13•4 years ago
|
||
This completed dt-fission-m3-mvp bug should have Fission Milestone M7 Beta.
Description
•