Closed Bug 1693269 Opened 4 years ago Closed 3 years ago

Stop using TargetMixin's descriptorFront attribute

Categories

(DevTools :: Framework, task)

Product:
DevTools
Component:
Framework
Type:
task

Tracking

(firefox90 fixed)

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(1 file)

Bug 1693269 - [devtools] Use descriptor directly instead of pulling it via current target.
(deleted), text/x-phabricator-request
Details

This will no longer work if we start spawning the top level target from the server side.
This will start with bug 1644397 and will be a blocker once we want to remove DescriptorFront.getTarget and let all targets, including the first top level one to be all created by the Watcher actor, on the server side.
This will break because all targets will be children of the watcher front, and no longer children of theirs descriptor.

I don't think there is any big blocker for doing this. This is most likely a tedious work of passing descriptorFront all where it is used.

Note that bug 1691681 will most likely group many usages of descriptor front in commands, where there will be an easy access to it.

Type: enhancement → task
Blocks: 1698891
Depends on: 1644397
No longer depends on: 1644397
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/775b9bda5dd0
[devtools] Use descriptor directly instead of pulling it via current target. r=nchevobbe

https://hg.mozilla.org/mozilla-central/rev/775b9bda5dd0

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: