Allow SitePermissions to store "temporary allow" state
Categories
(Firefox :: Site Permissions, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: mconley, Assigned: pbz)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Whiteboard: [proton-door-hangers])
Attachments
(5 files)
SitePermissions doesn't currently allow us to do temporary allow. We're going to need this ability in order to improve some of our WebRTC permission UX.
What we're effectively looking for is for SitePermissions to be able to remember that a particular camera or microphone device was permitted for a particular domain in a <browser>, for a period of time.
Perhaps importantly, any kind of "deny" on the top-level frame domain should probably override any temporary allow for any device on any subframe in that browser.
|
||
Updated•3 years ago
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
This enables setting temporary permissions with state SitePermissions.ALLOW.
In order to safely support this it updates the temporary permission map
to key non-BLOCK permissions by URI prePath. BLOCK permissions are still
keyed by baseDomain to prevent DoS.
|
|
Assignee | |
Comment 2•3 years ago
|
||
- Added a permission setter argument to pass custom expiry time.
- Refactored TemporaryPermissions to use timeouts instead of timestamps.
This is needed, so we directly get a callback once a permission expires
and can notify the UI.
Previously we would only knew if a permission expired if we called the getter.
Depends on D105982
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D105983
|
|
Assignee | |
Comment 4•3 years ago
|
||
|
||
Comment 5•3 years ago
|
||
As per guidance from Vicky, for tracking, we're marking all the bugs that people are working on as P1.
|
|
Assignee | |
Comment 6•3 years ago
|
||
Pushed by pzuhlcke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0c4a60f7d65b Temporary ALLOW SitePermissions. r=johannh https://hg.mozilla.org/integration/autoland/rev/546ecbe4699f Support custom expiry times for temporary SitePermissions. r=johannh https://hg.mozilla.org/integration/autoland/rev/79ebd82c278d Added option to pass custom URI for setting temporary permissions. r=johannh https://hg.mozilla.org/integration/autoland/rev/2ee50cd896d8 Only clear temporary block permissions on user reload. r=johannh https://hg.mozilla.org/integration/autoland/rev/c93e212cd0dd Tests for new SitePermissions expiry behavior. r=johannh
|
||
Comment 8•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0c4a60f7d65b
https://hg.mozilla.org/mozilla-central/rev/546ecbe4699f
https://hg.mozilla.org/mozilla-central/rev/79ebd82c278d
https://hg.mozilla.org/mozilla-central/rev/2ee50cd896d8
https://hg.mozilla.org/mozilla-central/rev/c93e212cd0dd
Description
•