Closed
Bug 1713578
Opened 3 years ago
Closed 3 years ago
Clean up leftover "PermissionStateChange" dispatch for temporary site permissions
Categories
(Firefox :: Site Permissions, task, P3)
Firefox
Site Permissions
Tracking
()
RESOLVED
FIXED
91 Branch
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: pbz, Assigned: pbz)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Bug 1693621 switched temporary SitePermissions from being timestamp based and lazily evaluated to timers. That means we no longer need to dispatch a PermissionStateChange event outside of SitePermissions for updating UI for the temporary permission state.
TemporaryPermissions dispatches the event on expiry here: https://searchfox.org/mozilla-central/rev/d3b116e554eb3546a95851e81f7ddc53d5b7e096/browser/modules/SitePermissions.jsm#846
We should remove leftover external dispatches:
https://searchfox.org/mozilla-central/rev/d3b116e554eb3546a95851e81f7ddc53d5b7e096/browser/actors/WebRTCParent.jsm#582-586
https://searchfox.org/mozilla-central/rev/d3b116e554eb3546a95851e81f7ddc53d5b7e096/browser/modules/PermissionUI.jsm#412-416
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → pbz
Status: NEW → ASSIGNED
Pushed by pzuhlcke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1e26527ec54d Removed leftover PermissionStateChange events. r=prathiksha
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•