Closed
Bug 1693851
Opened 4 years ago
Closed 4 years ago
Investigate and fix tests that fail when the Proton AppMenu is enabled by default
Categories
(Firefox :: Menus, task, P1)
Firefox
Menus
Tracking
()
RESOLVED
FIXED
88 Branch
Tracking | Status | |
---|---|---|
firefox88 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
(Whiteboard: [proton-hamburger-menu])
Attachments
(2 files)
As it says on the tin. We don't want to get surprised by an orange tree when we turn this thing on.
Assignee | ||
Comment 1•4 years ago
|
||
Try build cooking here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=297f6368971856e903b5c6f3515fca3c61d04154
Assignee | ||
Comment 2•4 years ago
|
||
Here's a list of mochitest-browser tests that need investigating(*):
- browser/base/content/test/protectionsUI/browser_protectionsUI.js
browser/base/content/test/protectionsUI/browser_protectionsUI_animation_2.js(failed due to previous failure)toolkit/components/pictureinpicture/tests/browser_videoSelection.js(intermittent)browser/components/uitour/test/browser_UITour2.jsbrowser/components/uitour/test/browser_UITour4.jsbrowser/components/uitour/test/browser_UITour5.jsbrowser/components/uitour/test/browser_UITour_availableTargets.jsbrowser/components/uitour/test/browser_fxa.js- browser/components/newtab/test/browser/browser_asrouter_whatsnewpanel.js
- browser/components/places/tests/browser/browser_panelview_bookmarks_delete.js
- browser/components/places/tests/browser/browser_stayopenmenu.js
- toolkit/components/passwordmgr/test/browser/browser_entry_point_telemetry.js
- toolkit/components/printing/tests/browser_window_print.js
- browser/base/content/test/sync/browser_sync.js
- browser/modules/test/browser/browser_UsageTelemetry_interaction.js
- browser/components/customizableui/test/browser_ctrl_click_panel_opening.js
- browser/components/customizableui/test/browser_library_after_appMenu.js
- browser/components/customizableui/test/browser_panel_keyboard_navigation.js
- browser/components/tests/browser/browser_quit_disabled.js
These should be re-checked after the Firefox Accounts panel bug (bug 1690131) is closed.
(*): Some of these might be intermittent test failures.
Depends on: 1690131
Updated•4 years ago
|
Severity: -- → N/A
Priority: -- → P3
Assignee | ||
Comment 3•4 years ago
|
||
The UITour issues should be addressed by bug 1694197 and bug 1694195.
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → mconley
Comment 4•4 years ago
|
||
As per guidance from Vicky, for tracking, we're marking all the bugs that people are working on as P1.
Priority: P3 → P1
Updated•4 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-288
Assignee | ||
Comment 5•4 years ago
|
||
Assignee | ||
Comment 6•4 years ago
|
||
Depends on D106380
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4937e561af74
Fix browser_sync.js tests when Proton AppMenu is enabled. r=markh
https://hg.mozilla.org/integration/autoland/rev/0ea3ac7c18b9
Fix some variety of tests so that they pass with and without Proton AppMenu enabled. r=emalysz
Comment 9•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4937e561af74
https://hg.mozilla.org/mozilla-central/rev/0ea3ac7c18b9
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•