Closed Bug 1694195 Opened 4 years ago Closed 4 years ago

Remove some targets from the UITour library

Categories

(Firefox :: Tours, task, P1)

Product:
Firefox
Component:
Tours
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

(Blocks 2 open bugs)

Details

(Keywords: helpwanted, Whiteboard: [proton-hamburger-menu][proton-toolbars])

Attachments

(1 file)

Bug 1694195 - Remove the customize and pageActionButton UITour targets. r?Gijs!
(deleted), text/x-phabricator-request
Details

There are a number of UITour targets that are going away, or would require re-engineering the UITour library to support. These are the ones I propose we remove:

  • The "customize" target. This menuitem will exist in the Proton AppMenu under "More Tools", but UITour isn't designed to go into submenus right now. Instead of adding that support, I think we can just remove the target.
  • The "pageActionButton" target.

In the future, we might re-add these targets, but for now, this seems like the simpler path.

As far as www.mozilla.org goes we're not using either of these targets today, so they should be fine to remove.

Keywords: helpwanted
Assignee: nobody → mconley
Blocks: 1693851

As per guidance from Vicky, for tracking, we're marking all the bugs that people are working on as P1.

Priority: -- → P1
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0fa7258e2017 Remove the customize and pageActionButton UITour targets. r=Gijs

https://hg.mozilla.org/mozilla-central/rev/0fa7258e2017

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: