Closed Bug 1694145 Opened 4 years ago Closed 3 years ago

Implement basic support for session.unsubscribe

Categories

(Remote Protocol :: WebDriver BiDi, task, P2)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
task
Points:
2

Tracking

(firefox96 fixed)

Status:
RESOLVED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox96 --- fixed

People

(Reporter: whimboo, Assigned: jdescottes)

References

(Depends on 1 open bug, Blocks 2 open bugs,
URL
)

Details

(Whiteboard: [bidi-m2-mvp], [wptsync upstream])

Attachments

(5 files, 2 obsolete files)

Bug 1694145 - [webdriver-bidi] Support unsubscribing from log.entryAdded events
(deleted), text/x-phabricator-request
Details
Bug 1694145 - [webdriver-bidi] Extract console api observer to dedicated listener class
(deleted), text/x-phabricator-request
Details
Bug 1694145 - [remote] Add removeSessionData API to RootMessageHandler
(deleted), text/x-phabricator-request
Details
Bug 1694145 - [wdspec] Add wdspec test for unsubscribe command
(deleted), text/x-phabricator-request
Details
Bug 1694145 - [wdspec] Add wdspec test for unsubscribing to log entryAdded
(deleted), text/x-phabricator-request
Details

For unsubscribing from events we need the following command implemented:
https://w3c.github.io/webdriver-bidi/#command-session-unsubscribe

Depends on: 1693838
Depends on: 1694389
Depends on: 1694390
Points: --- → 2
Priority: -- → P2
Priority: P2 → P3
Depends on: 1723102
Blocks: 1724669
No longer depends on: 1694144
Whiteboard: [bidi-m1-mvp] → [bidi-m2-mvp]
Priority: P3 → --
Blocks: 1730469
Points: 2 → ---
Priority: -- → P2
Points: --- → 2
Blocks: 1731565
No longer blocks: 1730469
Depends on: 1713443
Attached file Bug 1694145 - [remote] Implement session.unsubscribe (obsolete) (deleted) —

Depends on D128115

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED

Add a new public command "unsubscribe" on the session module
Add a new API on RootMessageHandler called removeSessionData.
The internal _applySessionData command now expects paramers containing "added" and/or "removed" arrays instead of only "values".
Browser mochitests and wdspec tests are updated to cover the new feature.

Attachment #9245332 - Attachment is obsolete: true

Let's block this on Bug 1731548. We should extract the ConsoleAPIObserver to a listener class similar to what is done in Bug 1731548, it will be easier to unsubscribe from all listeners if they share a common interface.

Depends on: 1731548
No longer depends on: 1723102
Summary: Implement session.unsubscribe → Implement basic support for session.unsubscribe
Blocks: 1723102

Depends on D132150
Adds a new wdspec test for unsubscribed. Implementation is almost identical to subscribe.

Depends on D132151

Adds a new API to RootMessageHandler which will be necessary to implement _unsubscribeEvent on root/log.jsm
Expand the current browser mochitest for session data to cover the new API.

Depends on D132021

No longer depends on: 1693838
Attachment #9252294 - Attachment description: Bug 1694145 - [remote] Implement session.unsubscribe → Bug 1694145 - [webdriver-bidi] Support unsubscribing from log.entryAdded events
Attachment #9252497 - Attachment is obsolete: true
Attachment #9252646 - Attachment description: Bug 1694145 - [webdriver-bidi] Add wdspec test for unsubscribe command → Bug 1694145 - [wdspec] Add wdspec test for unsubscribe command
Attachment #9252647 - Attachment description: Bug 1694145 - [webdriver-bidi] Add wdspec test for unsubscribing to log entryAdded → Bug 1694145 - [wdspec] Add wdspec test for unsubscribing to log entryAdded
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6e1737d57e2c [webdriver-bidi] Extract console api observer to dedicated listener class r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/9f8ab9bfc38d [remote] Add removeSessionData API to RootMessageHandler r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/477637639466 [webdriver-bidi] Support unsubscribing from log.entryAdded events r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/56aa27ebfa80 [wdspec] Add wdspec test for unsubscribe command r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/2907734e3e22 [wdspec] Add wdspec test for unsubscribing to log entryAdded r=webdriver-reviewers,whimboo,jgraham
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/31855 for changes under testing/web-platform/tests
Whiteboard: [bidi-m2-mvp] → [bidi-m2-mvp], [wptsync upstream]
Regressions: 1744163
No longer regressions: 1744163
Upstream PR merged by moz-wptsync-bot
Blocks: 1730469
Blocks: 1790466
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: