Closed Bug 1723102 Opened 3 years ago Closed 2 years ago

Implement full support for "session.subscribe" and "session.unsubscribe" commands

Categories

(Remote Protocol :: WebDriver BiDi, task, P1)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
task
Points:
8

Tracking

(firefox109 fixed)

Status:
RESOLVED FIXED
Milestone:
109 Branch
Tracking Flags:
Tracking Status
firefox109 --- fixed

People

(Reporter: whimboo, Assigned: Sasha)

References

(Blocks 4 open bugs,
URL
)

Details

(Whiteboard: [webdriver:m5], [wptsync upstream], [webdriver:relnote] )

Attachments

(3 files, 1 obsolete file)

Bug 1723102 - [bidi] Implement full support for session.subscribe and session.unsubscribe commands.
(deleted), text/x-phabricator-request
Details
Bug 1723102 - [wdpspec] Add bidi_subscribe fixture to automatically unsubscribe at the end of a test.
(deleted), text/x-phabricator-request
Details
Bug 1723102 - [wdpspec] Add tests for session.subscribe and session.unsubscribe.
(deleted), text/x-phabricator-request
Details

With bug 1694144 basic support for the session.subscribe command will be added so that it just works for log.entryAdded. To be fully BiDi compatible more work will be necessary.

We should follow the following part of the specification, and if needed file dependency bugs if blockers come up:

https://w3c.github.io/webdriver-bidi/#command-session-subscribe

Blocks: 1724669
Assignee: nobody → hskupin
Status: NEW → ASSIGNED

Only added a WIP that contains code that we do not yet want to see in the session module for bug 1694144.

Assignee: hskupin → nobody
Status: ASSIGNED → NEW
Assignee: nobody → hskupin
Attachment #9235770 - Attachment description: WIP: Bug 1723102 - [WebDriver BiDi] Add full support for session.subscribe. → Bug 1723102 - [WebDriver BiDi] Add full support for session.subscribe.
Status: NEW → ASSIGNED
Whiteboard: [bidi-m1-mvp] → [bidi-m2-mvp]
Priority: P3 → --
Priority: -- → P2
Points: --- → 13
Blocks: 1731556
No longer blocks: 1724669

Not actually working on this bug right now given that it is blocked on other bugs that need to be fixed first.

Assignee: hskupin → nobody
Status: ASSIGNED → NEW
Priority: P2 → P3
No longer blocks: 1694145
Summary: Implement full support for session.subscribe → Implement full support for session.subscribe and session.unsubscribe
Depends on: 1694145

In Bug 1694145 we will land a basic implementation for session.unsubscribe which will match our current implementation for session.subscribe.
After that we should implement features simultaneously for subscribe and unsubscribe, so this bug is repurposed to handle the complete implementation for both subscribe and unsubscribe.

No longer depends on: 1693838
No longer depends on: 1694389, 1694390
Priority: P3 → --
Whiteboard: [bidi-m2-mvp]
Whiteboard: [bidi-m3-mvp]
Blocks: 1730469
Depends on: 1747222
Priority: -- → P3
Blocks: 1731565
Priority: P3 → P2
Whiteboard: [bidi-m3-mvp] → [webdriver:backlog]

Blocking on Bug 1763137

Depends on: 1763137

I'll have to split this bug into two (subscribe and unsubscribe). I'll do this later today.

Blocks: 1790362
Flags: needinfo?(hskupin)
Priority: P2 → P1
Whiteboard: [webdriver:backlog] → [webdriver:m5]

As discussed today in the triage meeting we are going to split-up this test into session.subscribe and session.unsubscribe. I'm going to file a new bug for the latter command in a minute.

No longer blocks: 1730469
Points: 13 → 8
Flags: needinfo?(hskupin)
Summary: Implement full support for session.subscribe and session.unsubscribe → Implement full support for session.subscribe command
Blocks: 1790466
Assignee: nobody → aborovova
Status: NEW → ASSIGNED
Blocks: 1754273
Attachment #9302043 - Attachment description: WIP: Bug 1723102 - [bidi] Implement full support for session.subscribe and session.unsubscribe commands. → Bug 1723102 - [bidi] Implement full support for session.subscribe and session.unsubscribe commands.
Attachment #9302044 - Attachment description: WIP: Bug 1723102 - [wdpspec] Do not unsubscribe from the events before subscribing. → Bug 1723102 - [wdpspec] Do not unsubscribe from the events before subscribing.
Attachment #9302045 - Attachment description: WIP: Bug 1723102 - [wdpspec] Add tests for session.subscribe and session.unsubscribe. → Bug 1723102 - [wdpspec] Add tests for session.subscribe and session.unsubscribe.
Duplicate of this bug: 1790466
Blocks: 1730469
Summary: Implement full support for session.subscribe command → Implement full support for "session.subscribe" and "session.unsubscribe" commands
Attachment #9235770 - Attachment is obsolete: true
Attachment #9302044 - Attachment description: Bug 1723102 - [wdpspec] Do not unsubscribe from the events before subscribing. → Bug 1723102 - [wdpspec] Add bidi_subscribe fixture to automatically unsubscribe at the end of a test.
Pushed by aborovova@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fb432fd5b045 [bidi] Implement full support for session.subscribe and session.unsubscribe commands. r=webdriver-reviewers,jdescottes,whimboo https://hg.mozilla.org/integration/autoland/rev/6b8a1f1803f8 [wdpspec] Add bidi_subscribe fixture to automatically unsubscribe at the end of a test. r=webdriver-reviewers,jdescottes,whimboo https://hg.mozilla.org/integration/autoland/rev/bec825dafefb [wdpspec] Add tests for session.subscribe and session.unsubscribe. r=webdriver-reviewers,jdescottes,whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/37400 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m5] → [webdriver:m5], [wptsync upstream]

https://hg.mozilla.org/mozilla-central/rev/fb432fd5b045
https://hg.mozilla.org/mozilla-central/rev/6b8a1f1803f8
https://hg.mozilla.org/mozilla-central/rev/bec825dafefb

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox109: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
Upstream PR was closed without merging
Upstream PR merged by jgraham
Whiteboard: [webdriver:m5], [wptsync upstream] → [webdriver:m5], [wptsync upstream], [webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: