Closed Bug 1694203 Opened 4 years ago Closed 4 years ago

Have RemoteAccessible and LocalAccessible share the same base class

Categories

(Core :: Disability Access APIs, task)

Product:
Core
Component:
Disability Access APIs
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

(Blocks 1 open bug)

Details

Attachments

(9 files)

Bug 1694203 - P1: Add Accessible and have LocalAccessible inherit from it. r?Jamie,morgan
(deleted), text/x-phabricator-request
Details
Bug 1694203 - P2: Add eNumericValue and eAction to generic types for use in proxy.
(deleted), text/x-phabricator-request
Details
Bug 1694203 - P3: Move type "Is" methods to Accessible base class. r?morgan,Jamie
(deleted), text/x-phabricator-request
Details
Bug 1694203 - P4: Move IsTextRole from HyperTextAccessible to base class. r?morgan,Jamie
(deleted), text/x-phabricator-request
Details
Bug 1694203 - P5: Add and implement virtual hierarchy functions. r?morgan,Jamie
(deleted), text/x-phabricator-request
Details
Bug 1694203 - P7: Define IsLink as a virtual method in Accessible. r?morgan,Jamie
(deleted), text/x-phabricator-request
Details
Bug 1694203 - P6: Virtualize Role() and implment in LocalAccessible. r?morgan,Jamie
(deleted), text/x-phabricator-request
Details
Bug 1694203 - P8: Rename ChildrenCount to ChildCount in RemoteAccessible. r?morgan,Jamie
(deleted), text/x-phabricator-request
Details
Bug 1694203 - P9: Have RemoteAccessible inherit from Accessible. r?morgan,Jamie
(deleted), text/x-phabricator-request
Details

This will allow polymorphism and unified code paths for remote/local cases.

eHasNumericValue should probably not be a state anyway. We need both of
these types because we currently send eHasNumericValue and
ActionCount != 0 as interface flags when creating proxies.

This will allow remote accessibles to use them as well.

Depends on D104914

This will allow us to more easily query IsTextRole in remote case.

This allows us to use polymorphism when retrieving children/parents from
local or remote accessibles.

This may be enough and we can un-virtualize IsLink. But for now, this
allows remote accessibles to call IsLink.

This will allow us to make this an override when inheriting from Accessible.

Depends on D106004

Attachment #9204637 - Attachment description: Bug 1694203 - P7: Virtualize Role() and implment in LocalAccessible. r?morgan,Jamie → Bug 1694203 - P6: Virtualize Role() and implment in LocalAccessible. r?morgan,Jamie
Attachment #9204636 - Attachment description: Bug 1694203 - P6: Have a base default implementation of IsLink. r?morgan,Jamie → Bug 1694203 - P7: Have a base default implementation of IsLink. r?morgan,Jamie
Blocks: a11y-ctw
Type: defect → task
Blocks: 1694565
Blocks: 1694569
Blocks: 1694572
Blocks: 1694573
Blocks: 1694574
Blocks: 1694865
Attachment #9204636 - Attachment description: Bug 1694203 - P7: Have a base default implementation of IsLink. r?morgan,Jamie → Bug 1694203 - P7: Define IsLink as a virtual method in Accessible. r?morgan,Jamie
Pushed by eisaacson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/234e57a8ea1a P1: Add Accessible and have LocalAccessible inherit from it. r=Jamie https://hg.mozilla.org/integration/autoland/rev/28f00d0ad7dc P2: Add eNumericValue and eAction to generic types for use in proxy. r=Jamie https://hg.mozilla.org/integration/autoland/rev/f198d171958c P3: Move type "Is" methods to Accessible base class. r=Jamie https://hg.mozilla.org/integration/autoland/rev/f542657c890d P4: Move IsTextRole from HyperTextAccessible to base class. r=Jamie https://hg.mozilla.org/integration/autoland/rev/872cdb2e07bd P5: Add and implement virtual hierarchy functions. r=Jamie https://hg.mozilla.org/integration/autoland/rev/9be66f33f6ec P6: Virtualize Role() and implment in LocalAccessible. r=Jamie https://hg.mozilla.org/integration/autoland/rev/f5377ed40101 P7: Define IsLink as a virtual method in Accessible. r=Jamie https://hg.mozilla.org/integration/autoland/rev/52da6fbbb6db P8: Rename ChildrenCount to ChildCount in RemoteAccessible. r=Jamie https://hg.mozilla.org/integration/autoland/rev/da6882bc37a7 P9: Have RemoteAccessible inherit from Accessible. r=Jamie
Regressions: 1699680
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: