Closed Bug 1699680 Opened 4 years ago Closed 4 years ago

Regression: AtkText no longer implemented on document

Categories

(Core :: Disability Access APIs, defect, P1)

Unspecified
Linux
defect

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox86 --- unaffected
firefox87 --- unaffected
firefox88 --- fixed
firefox89 --- fixed

People

(Reporter: jdiggs, Assigned: eeejay)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Steps to reproduce:

  1. Launch Firefox Nightly
  2. View any page (e.g. mozilla.org)
  3. Launch Accerciser and examine the interfaces implemented by the document

Expected results: Text would be implemented.

Actual results: Text is not implemented.

Impact: Orca relies upon the text interface for many things including. This breaks (at least) searching for the caret location on a newly-loaded page. My guess is that it breaks other things too....

Ouch. This is very nasty.

Eitan, I'm guessing this is a regression from bug 1694203 p9. I notice that DocAccessible doesn't get eHyperTextType, so checking IsHyperText() in the ATK code won't return true for documents.

Severity: -- → S2
Flags: needinfo?(eitan)
Keywords: regression
Priority: -- → P1
Regressed by: 1694203
Has Regression Range: --- → yes

Oops yea that's bad. Fix incoming.

Flags: needinfo?(eitan)
Depends on: 1700166

Depends on D109384

Assignee: nobody → eitan
Status: NEW → ASSIGNED
Pushed by eisaacson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9799868fc448 Add HyperText interface to remote docs. r=morgan
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Please request uplift to 88.

Flags: needinfo?(eitan)

Comment on attachment 9210816 [details]
Bug 1699680 - Add HyperText interface to remote docs. r?morgan

Beta/Release Uplift Approval Request

  • User impact if declined: This causes a major bug for screen reader users in linux
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: Bug 1700166
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This change has test coverage.
  • String changes made/needed:
Flags: needinfo?(eitan)
Attachment #9210816 - Flags: approval-mozilla-beta?

Comment on attachment 9210816 [details]
Bug 1699680 - Add HyperText interface to remote docs. r?morgan

Approved for 88.0b3.

Attachment #9210816 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: