Break on > Attribute Modification doesn't work for style attribute mutations or Shadow DOM
Categories
(DevTools :: Debugger, defect, P3)
Tracking
(firefox88 fixed)
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Blocks 4 open bugs)
Details
Attachments
(4 files)
What were you doing?
Trying to debug something by breaking when its style attribute changed.
What happened?
Didn't break.
What should have happened?
Break.
|
Assignee | |
Comment 1•3 years ago
|
||
Ah, hmm... This works with dom.mutation-events.cssom.disabled=false. Does devtools use mutation events for this? :/
|
|
Assignee | |
Comment 2•3 years ago
|
||
So it seems... And that's problematic, because those events don't fire in e.g. shadow trees. We need to find a way for this not to depend on mutation listeners...
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 3•3 years ago
|
||
Yep, also broken on Shadow DOM...
|
|
Assignee | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 4•3 years ago
|
||
|
|
Assignee | |
Comment 5•3 years ago
|
||
Use internal events which get fired for CSSOM changes, and in Shadow
DOM. This will also allow us to remove mutation events in the future.
Depends on D106273
|
|
Assignee | |
Comment 7•3 years ago
|
||
Honza, do you know where to best add a test for this? I only saw devtools/client/inspector/markup/test/browser_markup_dom_mutation_breakpoints.js...
|
|
||
Comment 8•3 years ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #7)
Honza, do you know where to best add a test for this? I only saw
devtools/client/inspector/markup/test/browser_markup_dom_mutation_breakpoints.js...
Replying in Phab
https://phabricator.services.mozilla.com/D106274
Honza
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3faa9b27e4a5 Rename Document.dontWarnAboutMutationEventsAndAllowSlowDOMMutations and other misc cleanup in Document. r=smaug https://hg.mozilla.org/integration/autoland/rev/c87745c8f28b Move devtools breakpoints out of mutation events. r=smaug,jdescottes
|
||
Comment 10•3 years ago
|
||
Backout by malexandru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/53407f6a9c27 Backed out 2 changesets on suspicion of causing dt crashes in nsINode::LastRelease.
|
||
Comment 11•3 years ago
|
||
Backed out 2 changesets (Bug 1694548) on suspicion of causing dt crashes in nsINode::LastRelease.
Backout link: https://hg.mozilla.org/integration/autoland/rev/53407f6a9c27425316b2fa3ec12c0ef8d5762b80
Failure log: https://treeherder.mozilla.org/logviewer?job_id=331767351&repo=autoland&lineNumber=25387
|
|
Assignee | |
Updated•3 years ago
|
|
|
||
Comment 12•3 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/31483e46e546 Rename Document.dontWarnAboutMutationEventsAndAllowSlowDOMMutations and other misc cleanup in Document. r=smaug https://hg.mozilla.org/integration/autoland/rev/8c202f711dbd Move devtools breakpoints out of mutation events. r=smaug,jdescottes
|
||
Comment 13•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/31483e46e546
https://hg.mozilla.org/mozilla-central/rev/8c202f711dbd
|
||
Comment 14•3 years ago
|
||
Thanks a lot for figuring this out and fixing it without regressing anything in the current DOM breakpoints Emilio!
Description
•