Closed
Bug 1694817
Opened 4 years ago
Closed 4 years ago
Investigate and fix tests that fail when the Proton Toolbar is enabled by default
Categories
(Firefox :: Toolbars and Customization, task, P1)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
88 Branch
Tracking | Status | |
---|---|---|
firefox88 | --- | fixed |
People
(Reporter: emmamalysz, Assigned: mstriemer)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-toolbar])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Similar to Bug 1693851, we need to see what tests will fail due to the toolbar button removals.
Sam had already pointed out browser_toolbarKeyNav.js
, but I'm going to do a try push to see if there are others
Reporter | ||
Updated•4 years ago
|
Updated•4 years ago
|
Whiteboard: [proton-toolbar]
Updated•4 years ago
|
Severity: -- → N/A
Priority: -- → P1
Updated•4 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-309
Assignee | ||
Comment 1•4 years ago
|
||
I ran this try build this morning. It looks like there are a lot of failures.
https://treeherder.mozilla.org/jobs?repo=try&revision=8cd77b2bad2acc0b5629db63cab2f99f2142bd72
Updated•4 years ago
|
Assignee: nobody → bigiri
Updated•4 years ago
|
Assignee: bigiri → mstriemer
Assignee | ||
Comment 2•4 years ago
|
||
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8dd76087ff2b
Fix tests that fail with browser.proton.toolbar.enabled r=Gijs
Comment 4•4 years ago
|
||
Backed out changeset 8dd76087ff2b (Bug 1694817) for causing failures in browser_UITour.js
Failure log: https://treeherder.mozilla.org/logviewer?job_id=332867444&repo=autoland&lineNumber=3666
Backout: https://hg.mozilla.org/integration/autoland/rev/fade5597112d5ab75d526d5ef5e35aa2b8166eec
Flags: needinfo?(mstriemer)
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/804e4071445e
Fix tests that fail with browser.proton.toolbar.enabled r=Gijs
Assignee | ||
Updated•4 years ago
|
Flags: needinfo?(mstriemer)
Comment 6•4 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•